[turbolizer] Improved display of perf profiling information.

[turbolizer] Improved display of perf profiling information.

All events recorded are shown in separate columns simulatneously, using
rectangles with heatmap-style colouring. Hovering over the shapes gives
the event name, count, and percentage.

BUG=

Committed: https://crrev.com/4a64e9497b476f57d65136852d315d347441080b
Cr-Commit-Position: refs/heads/master@{#39408}

[alegil02, 2016-08-09 15:18:00]

Description was changed from

==========
[turbolizer] Improved display of perf profiling information.

All events recorded are shown in separate columns simulatneously, using
rectangles with heatmap-style colouring. Hovering over the shapes gives
the event name, count, and percentage.

BUG=
==========

to

==========
[turbolizer] Improved display of perf profiling information.

All events recorded are shown in separate columns simulatneously, using
rectangles with heatmap-style colouring. Hovering over the shapes gives
the event name, count, and percentage.

BUG=
==========

[alegil02, 2016-08-09 15:18:00]

alexander.gilday2@arm.com changed reviewers:
+ danno@chromium.org

[danno, 2016-08-09 15:56:14]

I like it. LGTM. nit: could you make the boxes a bit bigger?

[alegil02, 2016-08-09 15:58:22]

On 2016/08/09 15:56:14, danno wrote:
> I like it. LGTM. nit: could you make the boxes a bit bigger?

The boxes are simply small utf-8 characters, I could increase the font size and
likely get larger line separation as a result. Or use a different utf-8
character that is bolder maybe? Let me know what you would prefer to do.

[danno, 2016-08-09 15:59:40]

Try bold, that just a few pixels would help.

[alegil02, 2016-08-09 16:08:22]

On 2016/08/09 15:59:40, danno wrote:
> Try bold, that just a few pixels would help.

Changing the font-weight doesn't seem to have any effect on the size of the
boxes. Would using a square (■) instead of rectangle (▮) work and not cause
confusion about the separate columns?

[danno, 2016-08-09 16:11:04]

On 2016/08/09 16:08:22, alegil02 wrote:
> On 2016/08/09 15:59:40, danno wrote:
> > Try bold, that just a few pixels would help.
> 
> Changing the font-weight doesn't seem to have any effect on the size of the
> boxes. Would using a square (■) instead of rectangle (▮) work and not cause
> confusion about the separate columns?

I like the square much better. Even together without a space in between it's OK,
although a space between them makes the mouse-over easier: ■ ■

[alegil02, 2016-08-09 16:15:06]

On 2016/08/09 16:11:04, danno wrote:
> On 2016/08/09 16:08:22, alegil02 wrote:
> > On 2016/08/09 15:59:40, danno wrote:
> > > Try bold, that just a few pixels would help.
> > 
> > Changing the font-weight doesn't seem to have any effect on the size of the
> > boxes. Would using a square (■) instead of rectangle (▮) work and not cause
> > confusion about the separate columns?
> 
> I like the square much better. Even together without a space in between it's
OK,
> although a space between them makes the mouse-over easier: ■ ■

We had some discussion about the inclusion of a space, ultimately deciding to
exclude it and have thinner columns. One other option would be to use one of the
fractions of a block characters that stack nicely:

▉▉▉
▉▉▉
▉▉▉

Thinner variants are possible (above is 7/8 of a full block).

[alegil02, 2016-08-16 15:09:23]

On 2016/08/09 16:15:06, alegil02 wrote:
> On 2016/08/09 16:11:04, danno wrote:
> > On 2016/08/09 16:08:22, alegil02 wrote:
> > > On 2016/08/09 15:59:40, danno wrote:
> > > > Try bold, that just a few pixels would help.
> > > 
> > > Changing the font-weight doesn't seem to have any effect on the size of
the
> > > boxes. Would using a square (■) instead of rectangle (▮) work and not
cause
> > > confusion about the separate columns?
> > 
> > I like the square much better. Even together without a space in between it's
> OK,
> > although a space between them makes the mouse-over easier: ■ ■
> 
> We had some discussion about the inclusion of a space, ultimately deciding to
> exclude it and have thinner columns. One other option would be to use one of
the
> fractions of a block characters that stack nicely:
> 
> ▉▉▉
> ▉▉▉
> ▉▉▉
> 
> Thinner variants are possible (above is 7/8 of a full block).

Hi, do you have any preference for squares or the block fractions?

[danno, 2016-09-10 00:30:31]

Sorry, I  was on vacation.

Block fractions are fine, but a little thinner might be better than 7/8

[alegil02, 2016-09-12 10:36:00]

On 2016/09/10 00:30:31, danno wrote:
> Sorry, I  was on vacation.
> 
> Block fractions are fine, but a little thinner might be better than 7/8

Thanks, danno. I've switched to 5/8 block fractions which I think are better.
PTAL.

[danno, 2016-09-14 01:09:46]

lgtm again, will put in the CQ

[danno, 2016-09-14 01:10:24]

The CQ bit was checked by danno@chromium.org

[commit-bot: I haz the power, 2016-09-14 01:10:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 01:56:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 01:56:08]

Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/12636)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[alegil02, 2016-09-14 09:20:04]

The CQ bit was checked by alexander.gilday2@arm.com

[alegil02, 2016-09-14 09:20:05]

The patchset sent to the CQ was uploaded after l-g-t-m from danno@chromium.org
Link to the patchset: https://codereview.chromium.org/2228553004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-14 09:20:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 09:45:10]

Description was changed from

==========
[turbolizer] Improved display of perf profiling information.

All events recorded are shown in separate columns simulatneously, using
rectangles with heatmap-style colouring. Hovering over the shapes gives
the event name, count, and percentage.

BUG=
==========

to

==========
[turbolizer] Improved display of perf profiling information.

All events recorded are shown in separate columns simulatneously, using
rectangles with heatmap-style colouring. Hovering over the shapes gives
the event name, count, and percentage.

BUG=
==========

[commit-bot: I haz the power, 2016-09-14 09:45:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-14 09:45:45]

Description was changed from

==========
[turbolizer] Improved display of perf profiling information.

All events recorded are shown in separate columns simulatneously, using
rectangles with heatmap-style colouring. Hovering over the shapes gives
the event name, count, and percentage.

BUG=
==========

to

==========
[turbolizer] Improved display of perf profiling information.

All events recorded are shown in separate columns simulatneously, using
rectangles with heatmap-style colouring. Hovering over the shapes gives
the event name, count, and percentage.

BUG=

Committed: https://crrev.com/4a64e9497b476f57d65136852d315d347441080b
Cr-Commit-Position: refs/heads/master@{#39408}
==========

[commit-bot: I haz the power, 2016-09-14 09:45:46]

Patchset 3 (id:??) landed as
https://crrev.com/4a64e9497b476f57d65136852d315d347441080b
Cr-Commit-Position: refs/heads/master@{#39408}