a provider of Physical Web pages.

components/ntp_snippets/category_factory.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/category_factory.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 
 namespace ntp_snippets {
 
 CategoryFactory::CategoryFactory() {
   // Add all local categories in a fixed order.
   AddKnownCategory(KnownCategories::OFFLINE_PAGES);
   AddKnownCategory(KnownCategories::BOOKMARKS);
+  AddKnownCategory(KnownCategories::PHYSICAL_WEB_PAGES);

[Marc Treib, 2016/08/10 16:22:03]

Have we decided on an order here?

[tschumann, 2016/08/10 17:37:57]

hehe... we should clarify the comment above and make clear that this will be the
default sorting order for local categories. That said, I guess adding it to the
end of the local categories should be fine. We might want to double-check with
Patrick, though.

[vitaliii, 2016/08/11 12:15:24]

If I understand right and this order defines the order of suggestions, then
go/zine-prd requires additional functionality, since "Nearby suggestions should
get a boost while the user is close to the suggestion as much as Offline
suggestions should get a boost when the user is offline.".

[Marc Treib, 2016/08/11 12:53:09]

That sounds reasonable, but for M54 we're going with a fixed ordering. Any
boosting isn't implemented yet.
Anyway, since this won't go live in M54, it doesn't matter right now :)

[vitaliii, 2016/08/11 14:29:58]

Acknowledged.

 }
 
 CategoryFactory::~CategoryFactory() {}
 
 Category CategoryFactory::FromKnownCategory(KnownCategories known_category) {
   if (known_category < KnownCategories::LOCAL_CATEGORIES_COUNT) {
     // Local categories should have been added already.
     DCHECK(CategoryExists(static_cast<int>(known_category)));
   } else {
     DCHECK_GT(known_category, KnownCategories::REMOTE_CATEGORIES_OFFSET);
@@ skipping 41 matching lines @@
                       Category(id));
   if (it != ordered_categories_.end())
     return *it;
 
   Category category(id);
   ordered_categories_.push_back(category);
   return category;
 }
 
 }  // namespace ntp_snippets