Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: components/ntp_snippets/category_factory.cc

Issue 2228553003: a provider of Physical Web pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: resolved compile error. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/ntp_snippets/category.h ('k') | components/ntp_snippets/features.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/category_factory.h" 5 #include "components/ntp_snippets/category_factory.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 10
11 namespace ntp_snippets { 11 namespace ntp_snippets {
12 12
13 CategoryFactory::CategoryFactory() { 13 CategoryFactory::CategoryFactory() {
14 // Add all local categories in a fixed order. 14 // Add all local categories in a fixed order.
15 AddKnownCategory(KnownCategories::DOWNLOADS); 15 AddKnownCategory(KnownCategories::DOWNLOADS);
16 AddKnownCategory(KnownCategories::RECENT_TABS); 16 AddKnownCategory(KnownCategories::RECENT_TABS);
17 AddKnownCategory(KnownCategories::BOOKMARKS); 17 AddKnownCategory(KnownCategories::BOOKMARKS);
18 AddKnownCategory(KnownCategories::PHYSICAL_WEB_PAGES);
18 } 19 }
19 20
20 CategoryFactory::~CategoryFactory() {} 21 CategoryFactory::~CategoryFactory() {}
21 22
22 Category CategoryFactory::FromKnownCategory(KnownCategories known_category) { 23 Category CategoryFactory::FromKnownCategory(KnownCategories known_category) {
23 if (known_category < KnownCategories::LOCAL_CATEGORIES_COUNT) { 24 if (known_category < KnownCategories::LOCAL_CATEGORIES_COUNT) {
24 // Local categories should have been added already. 25 // Local categories should have been added already.
25 DCHECK(CategoryExists(static_cast<int>(known_category))); 26 DCHECK(CategoryExists(static_cast<int>(known_category)));
26 } else { 27 } else {
27 DCHECK_GT(known_category, KnownCategories::REMOTE_CATEGORIES_OFFSET); 28 DCHECK_GT(known_category, KnownCategories::REMOTE_CATEGORIES_OFFSET);
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 Category(id)); 70 Category(id));
70 if (it != ordered_categories_.end()) 71 if (it != ordered_categories_.end())
71 return *it; 72 return *it;
72 73
73 Category category(id); 74 Category category(id);
74 ordered_categories_.push_back(category); 75 ordered_categories_.push_back(category);
75 return category; 76 return category;
76 } 77 }
77 78
78 } // namespace ntp_snippets 79 } // namespace ntp_snippets
OLDNEW
« no previous file with comments | « components/ntp_snippets/category.h ('k') | components/ntp_snippets/features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698