components/ntp_snippets/mock_content_suggestions_provider_observer.cc - Issue 2228553003: a provider of Physical Web pages.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/mock_content_suggestions_provider_observer.cc

Issue 2228553003: a provider of Physical Web pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git cl format Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/ntp_snippets/mock_content_suggestions_provider_observer.h ('K') | « components/ntp_snippets/mock_content_suggestions_provider_observer.h ('k') | components/ntp_snippets/ntp_snippets_service_unittest.cc » ('j') | components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/ntp_snippets/mock_content_suggestions_provider_observer.h"

	6

	7 namespace ntp_snippets {

	8

	9 MockContentSuggestionsProviderObserver::

	10 MockContentSuggestionsProviderObserver() {}

	11

	12 MockContentSuggestionsProviderObserver::

	13 ~MockContentSuggestionsProviderObserver() {}

	14

	15 void MockContentSuggestionsProviderObserver::OnNewSuggestions(

	16 ContentSuggestionsProvider* provider,

	17 Category category,

	18 std::vector<ContentSuggestion> suggestions) {

	19 std::list<ContentSuggestion> suggestions_list;

	20 for (auto& suggestion : suggestions) {
	Bernhard Bauer 2016/08/12 13:49:06 Can you use the actual type here? It's not that mu Can you use the actual type here? It's not that much longer. vitaliii 2016/08/16 07:31:21 Done. Show quoted text On 2016/08/12 13:49:06, Bernhard Bauer wrote: > Can you use the actual type here? It's not that much longer. Done.
	21 suggestions_list.emplace_back(std::move(suggestion));
	Bernhard Bauer 2016/08/12 13:49:06 Same comment about push_back() applies here. Same comment about push_back() applies here. vitaliii 2016/08/16 07:31:21 Done. Show quoted text On 2016/08/12 13:49:06, Bernhard Bauer wrote: > Same comment about push_back() applies here. Done.
	22 }

	23 OnNewSuggestions(provider, category, suggestions_list);

	24 }

	25

	26 } // namespace ntp_snippets

OLD	NEW