a provider of Physical Web pages.

components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS_PROVIDER_H_
+#define COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS_PROVIDER_H_
+
+#include <string>
+#include <vector>
+
+#include "base/callback_forward.h"
+#include "components/ntp_snippets/category.h"
+#include "components/ntp_snippets/category_factory.h"
+#include "components/ntp_snippets/category_status.h"
+#include "components/ntp_snippets/content_suggestion.h"
+#include "components/ntp_snippets/content_suggestions_provider.h"
+
+namespace gfx {
+class Image;
+}
+
+namespace ntp_snippets {
+
+// TODO(vitaliii): remove when Physical Web C++ interface is provided.
+class UrlInfo {

[tschumann, 2016/08/09 15:24:59]

nit: if all members are public and the class doesn't contain any functionality,
you should make it a struct.

[vitaliii, 2016/08/10 14:18:41]

Done.

+ public:
+  GURL raw_url;
+  double distance;
+  base::Time scan_time;
+  GURL site_url;
+  GURL icon_url;
+  std::string title;
+  std::string description;
+  double ranking_weight;
+};
+
+// Provides content suggestions from the Physical Web Service.
+class PhysicalWebPageSuggestionsProvider
+    : public ContentSuggestionsProvider {
+ public:
+  PhysicalWebPageSuggestionsProvider(
+      ContentSuggestionsProvider::Observer* observer,
+      CategoryFactory* category_factory);
+  ~PhysicalWebPageSuggestionsProvider() override;
+
+ private:
+  // ContentSuggestionsProvider implementation.
+  std::vector<Category> GetProvidedCategories() override;
+  CategoryStatus GetCategoryStatus(Category category) override;
+  void DismissSuggestion(const std::string& suggestion_id) override;
+  void FetchSuggestionImage(const std::string& suggestion_id,
+                            const ImageFetchedCallback& callback) override;
+  void ClearCachedSuggestionsForDebugging() override;
+  void ClearDismissedSuggestionsForDebugging() override;
+
+  // UrlManager::Listener implementation

[Marc Treib, 2016/08/09 12:45:17]

No, it isn't :)

[vitaliii, 2016/08/10 14:18:41]

Do you mean that PhysicalWebPageSuggestionsProvider is not inherited from
UrlManager::Listener?
If yes, there is nothing to inherit from, since C++ interface is not provided
yet.

Or did you mean that it was private?

+  void onDisplayableUrlsChanged(const std::vector<UrlInfo>& urls);

[Marc Treib, 2016/08/09 12:45:17]

OnDisplayableUrlsChanged (capitalize)

[vitaliii, 2016/08/10 14:18:41]

Done.

+
+  // Updates the |category_status_| and notifies the |observer_|, if necessary.

[tschumann, 2016/08/09 15:24:59]

private methods are implementation details and only exposed in the header for
technical reasons. No need to document those in the header -- better put such
comments inside the .cc file at the method's implementation (however, if the
code is simple, the comment won't likely be needed).

[vitaliii, 2016/08/10 14:18:42]

Done.

+  void NotifyStatusChanged(CategoryStatus new_status);
+
+  CategoryStatus category_status_;
+

[tschumann, 2016/08/09 15:24:59]

you can drop the blank line between the two variables.

[vitaliii, 2016/08/10 14:18:42]

Done.

+  const Category provided_category_;
+
+  DISALLOW_COPY_AND_ASSIGN(PhysicalWebPageSuggestionsProvider);
+};
+
+}  // namespace ntp_snippets
+
+#endif  // COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS_PROVIDER_H_