Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2228543003: Update Mac build instructions with GN (Closed)

Created:
4 years, 4 months ago by vabr (Chromium)
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Mac build instructions with GN This CL adds basic info on using GN on Mac. It also removes GYP references, because GYP has been deprecated. R=sdefresne@chromium.org,rsesek@chromium.org BUG=635881

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -49 lines) Patch
M docs/mac_build_instructions.md View 3 chunks +8 lines, -49 lines 2 comments Download

Messages

Total messages: 4 (1 generated)
vabr (Chromium)
Hi Robert and Sylvain! A colleague of mine surprised me with a question about GN+Xcode ...
4 years, 4 months ago (2016-08-09 13:13:40 UTC) #1
Robert Sesek
Nico already has a CL out for this: https://codereview.chromium.org/2225903003/
4 years, 4 months ago (2016-08-09 13:14:30 UTC) #2
vabr (Chromium)
4 years, 4 months ago (2016-08-09 13:26:51 UTC) #3 
On 2016/08/09 13:14:30, Robert Sesek wrote:
> Nico already has a CL out for this:
https://codereview.chromium.org/2225903003/

Sweet, thanks for sharing! I'll close this one.

Powered by Google App Engine
This is Rietveld 408576698