Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: runtime/bin/socket.h

Issue 2228503007: Fixes memory leaks in the eventhandler (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/eventhandler_macos.cc ('k') | runtime/bin/socket.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket.h
diff --git a/runtime/bin/socket.h b/runtime/bin/socket.h
index 6a50d796da61ab37c81820a7c5098ef07dba7cca..332ec19c9309a6f23ede38b16eb887bce9072f15 100644
--- a/runtime/bin/socket.h
+++ b/runtime/bin/socket.h
@@ -402,6 +402,7 @@ class ListeningSocketRegistry {
ListeningSocketRegistry() : mutex_(new Mutex()) {}
~ListeningSocketRegistry() {
+ CloseAllSafe();
delete mutex_;
mutex_ = NULL;
}
@@ -437,6 +438,10 @@ class ListeningSocketRegistry {
return NULL;
}
+ bool CloseOneSafe(OSSocket* os_socket);
+ void CloseAllSafe();
+
+ // TODO(zra): Replace std::map with the HashMap in platform/hashmap.h.
std::map<intptr_t, OSSocket*> sockets_by_port_;
std::map<intptr_t, OSSocket*> sockets_by_fd_;
Mutex *mutex_;
« no previous file with comments | « runtime/bin/eventhandler_macos.cc ('k') | runtime/bin/socket.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698