Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2228503004: [Interpreter] Don't try to create bytecode array if HasStackOverflow(). (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Don't try to create bytecode array if HasStackOverflow(). BUG=chromium:635429 Committed: https://crrev.com/c1ae15d930b7ef49df23d297fd99ebc027f31346 Cr-Commit-Position: refs/heads/master@{#38474}

Patch Set 1 #

Patch Set 2 : Add regression test #

Total comments: 2

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-635429.js View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
rmcilroy
Michi, PTAL, thanks.
4 years, 4 months ago (2016-08-08 15:32:14 UTC) #6
Michael Starzinger
LGTM modulo test case failures. https://codereview.chromium.org/2228503004/diff/20001/test/mjsunit/regress/regress-635429.js File test/mjsunit/regress/regress-635429.js (right): https://codereview.chromium.org/2228503004/diff/20001/test/mjsunit/regress/regress-635429.js#newcode10 test/mjsunit/regress/regress-635429.js:10: foo(); Needs to be ...
4 years, 4 months ago (2016-08-08 17:38:38 UTC) #9
rmcilroy
https://codereview.chromium.org/2228503004/diff/20001/test/mjsunit/regress/regress-635429.js File test/mjsunit/regress/regress-635429.js (right): https://codereview.chromium.org/2228503004/diff/20001/test/mjsunit/regress/regress-635429.js#newcode10 test/mjsunit/regress/regress-635429.js:10: foo(); On 2016/08/08 17:38:38, Michael Starzinger wrote: > Needs ...
4 years, 4 months ago (2016-08-09 07:18:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228503004/40001
4 years, 4 months ago (2016-08-09 07:19:03 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-09 07:20:57 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 07:24:18 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c1ae15d930b7ef49df23d297fd99ebc027f31346
Cr-Commit-Position: refs/heads/master@{#38474}

Powered by Google App Engine
This is Rietveld 408576698