Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22285004: New analyzer_experimental snapshot. (Closed)

Created:
7 years, 4 months ago by scheglov
Modified:
7 years, 4 months ago
Reviewers:
ahe, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New analyzer_experimental snapshot. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=25902

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4582 lines, -2505 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 3 chunks +19 lines, -4 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_engine_io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_junit.dart View 4 chunks +0 lines, -16 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java View 4 chunks +25 lines, -0 lines 1 comment Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 6 chunks +84 lines, -49 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/EngineSemanticProcessor.java View 1 chunk +4 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 13 chunks +54 lines, -13 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java View 2 chunks +10 lines, -8 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ObjectSemanticProcessor.java View 2 chunks +9 lines, -0 lines 0 comments Download
A editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/TypeSemanticProcessor.java View 1 chunk +58 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 6 chunks +45 lines, -5 lines 1 comment Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/CollectionSemanticProcessorTest.java View 1 chunk +8 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java View 3 chunks +22 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/TestAll.java View 1 chunk +1 line, -0 lines 0 comments Download
A + editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/TypeSemanticProcessorTest.java View 1 chunk +12 lines, -19 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/ast.dart View 81 chunks +423 lines, -215 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/element.dart View 12 chunks +66 lines, -18 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/engine.dart View 51 chunks +1001 lines, -252 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/error.dart View 122 chunks +268 lines, -249 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/html.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/instrumentation.dart View 5 chunks +16 lines, -5 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_core.dart View 3 chunks +19 lines, -4 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_engine_io.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_junit.dart View 6 chunks +5 lines, -21 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/parser.dart View 15 chunks +107 lines, -71 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/resolver.dart View 103 chunks +1442 lines, -1105 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/scanner.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source.dart View 5 chunks +12 lines, -8 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source_io.dart View 2 chunks +14 lines, -2 lines 0 comments Download
A + pkg/analyzer_experimental/lib/src/generated/utilities_collection.dart View 2 chunks +33 lines, -36 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/utilities_dart.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/services/formatter_impl.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/ast_test.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/element_test.dart View 4 chunks +22 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/parser_test.dart View 12 chunks +75 lines, -34 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 76 chunks +705 lines, -343 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/scanner_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
7 years, 4 months ago (2013-08-07 20:11:26 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/22285004/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java File editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java (right): https://codereview.chromium.org/22285004/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java#newcode1031 editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java:1031: // XXX Remove? https://codereview.chromium.org/22285004/diff/1/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java File editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java (right): https://codereview.chromium.org/22285004/diff/1/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java#newcode445 ...
7 years, 4 months ago (2013-08-07 20:31:29 UTC) #2
scheglov
Committed patchset #1 manually as r25902 (presubmit successful).
7 years, 4 months ago (2013-08-07 21:15:55 UTC) #3
ahe
This breaks pkg/analyzer_experimental/test/generated/ast_test.dart on dart2js as it now depends on dart:io.
7 years, 4 months ago (2013-08-08 11:06:21 UTC) #4
scheglov
7 years, 4 months ago (2013-08-08 16:45:36 UTC) #5
Message was sent while issue was closed. 
On 2013/08/08 11:06:21, ahe wrote:
> This breaks pkg/analyzer_experimental/test/generated/ast_test.dart on dart2js
as
> it now depends on dart:io.

Will be fixed with this CL.
https://codereview.chromium.org/22325013

Powered by Google App Engine
This is Rietveld 408576698