Fix various grit python paths.

Fix various grit python paths.

The code was appending grit to the python search path. This leads to
issues in environments where grit is installed as a system package.
Make sure to prepend the grit module from the source tree to the
search path to give it precedence over any other grit modules.

BUG=None
TEST=Build is green.

Committed: https://crrev.com/6222f573984beee1dbdcb9004a0bf367531b318b
Cr-Commit-Position: refs/heads/master@{#411585}

[Mattias Nissler (ping if slow), 2016-08-08 11:41:34]

The CQ bit was checked by mnissler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 11:41:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mattias Nissler (ping if slow), 2016-08-08 11:42:48]

mnissler@chromium.org changed reviewers:
+ thakis@chromium.org

[Mattias Nissler (ping if slow), 2016-08-08 11:42:49]

Nico, here's a CL to fix the grit search path confusion discussed per email.

[commit-bot: I haz the power, 2016-08-08 12:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 12:29:19]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-08-08 13:09:20]

On 2016/08/08 11:42:49, Mattias Nissler (ping if slow) wrote:
> Nico, here's a CL to fix the grit search path confusion discussed per email.

Thanks! Why insert at 1? Most other places insert at 0.

[Mattias Nissler (ping if slow), 2016-08-08 13:24:54]

On 2016/08/08 13:09:20, Nico wrote:
> On 2016/08/08 11:42:49, Mattias Nissler (ping if slow) wrote:
> > Nico, here's a CL to fix the grit search path confusion discussed per email.
> 
> Thanks! Why insert at 1? Most other places insert at 0.

The first entry in sys.path is the directory containing the script, or current
directory (see
https://docs.python.org/3/tutorial/modules.html#the-module-search-path). It
makes sense to leave that as is, to give local python modules even higher
precedence. Note that we have both insert-at-1 and insert-at-0 instances present
in the chromium source tree. In practice, it probably doesn't matter much, but
insert-at-1 seems more correct to me as it produces what you'd get by running
PYTHONPATH=/path/to/dir:$PYTHONPATH /path/to/script.py

[Mattias Nissler (ping if slow), 2016-08-08 13:24:58]

On 2016/08/08 13:09:20, Nico wrote:
> On 2016/08/08 11:42:49, Mattias Nissler (ping if slow) wrote:
> > Nico, here's a CL to fix the grit search path confusion discussed per email.
> 
> Thanks! Why insert at 1? Most other places insert at 0.

The first entry in sys.path is the directory containing the script, or current
directory (see
https://docs.python.org/3/tutorial/modules.html#the-module-search-path). It
makes sense to leave that as is, to give local python modules even higher
precedence. Note that we have both insert-at-1 and insert-at-0 instances present
in the chromium source tree. In practice, it probably doesn't matter much, but
insert-at-1 seems more correct to me as it produces what you'd get by running
PYTHONPATH=/path/to/dir:$PYTHONPATH /path/to/script.py

[Nico, 2016-08-08 19:41:56]

lgtm, fair enough

[Nico, 2016-08-08 19:41:59]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-08-08 19:42:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 19:51:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 19:51:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mattias Nissler (ping if slow), 2016-08-09 09:24:59]

Brett, can I get a src/OWNERS stamp for this?

[Nico, 2016-08-09 10:20:49]

(I think this cl is covered by the "when is it ok to tbr" section in our
docs)

On Aug 9, 2016 5:25 AM, <mnissler@chromium.org> wrote:

> Brett, can I get a src/OWNERS stamp for this?
>
> https://codereview.chromium.org/2228463002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mattias Nissler (ping if slow), 2016-08-09 10:28:49]

On 2016/08/09 10:20:49, Nico (away until Mon Aug 22) wrote:
> (I think this cl is covered by the "when is it ok to tbr" section in our
> docs)

Agreed - I'm in no rush however. Do you need this rather sooner than later?

[Nico, 2016-08-09 10:43:43]

I'm fine with waiting if you are :-)

On Aug 9, 2016 6:28 AM, <mnissler@chromium.org> wrote:

> On 2016/08/09 10:20:49, Nico (away until Mon Aug 22) wrote:
> > (I think this cl is covered by the "when is it ok to tbr" section in our
> > docs)
>
> Agreed - I'm in no rush however. Do you need this rather sooner than later?
>
> https://codereview.chromium.org/2228463002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[estevenson, 2016-08-09 18:06:47]

estevenson@chromium.org changed reviewers:
+ brettw@chromium.org, estevenson@chromium.org

[estevenson, 2016-08-09 18:06:48]

+brettw

[brettw, 2016-08-09 20:01:28]

rs lgtm

[Mattias Nissler (ping if slow), 2016-08-09 20:27:56]

The CQ bit was checked by mnissler@chromium.org

[commit-bot: I haz the power, 2016-08-09 20:28:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 22:02:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 22:02:59]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mattias Nissler (ping if slow), 2016-08-10 08:54:15]

The CQ bit was checked by mnissler@chromium.org

[commit-bot: I haz the power, 2016-08-10 08:54:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 10:17:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 10:17:09]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mattias Nissler (ping if slow), 2016-08-12 08:25:01]

The CQ bit was checked by mnissler@chromium.org

[commit-bot: I haz the power, 2016-08-12 08:25:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 09:08:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-12 09:10:09]

Description was changed from

==========
Fix various grit python paths.

The code was appending grit to the python search path. This leads to
issues in environments where grit is installed as a system package.
Make sure to prepend the grit module from the source tree to the
search path to give it precedence over any other grit modules.

BUG=None
TEST=Build is green.
==========

to

==========
Fix various grit python paths.

The code was appending grit to the python search path. This leads to
issues in environments where grit is installed as a system package.
Make sure to prepend the grit module from the source tree to the
search path to give it precedence over any other grit modules.

BUG=None
TEST=Build is green.

Committed: https://crrev.com/6222f573984beee1dbdcb9004a0bf367531b318b
Cr-Commit-Position: refs/heads/master@{#411585}
==========

[commit-bot: I haz the power, 2016-08-12 09:10:11]

Patchset 1 (id:??) landed as
https://crrev.com/6222f573984beee1dbdcb9004a0bf367531b318b
Cr-Commit-Position: refs/heads/master@{#411585}