tools/perf/page_sets/dual_browser_story.py - Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/dual_browser_story.py

Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Petr's comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/dual_browser_story.py

diff --git a/tools/perf/page_sets/dual_browser_story.py b/tools/perf/page_sets/dual_browser_story.py

index debaf60207cbf2997a297a58ebe5cda647c48d1f..6edaf60b4c228da2794250980dd4eddb99a33bfc 100644

--- a/tools/perf/page_sets/dual_browser_story.py

+++ b/tools/perf/page_sets/dual_browser_story.py

@@ -254,14 +254,14 @@ class DualBrowserStorySet(story_module.StorySet):

for query, url in zip(SEARCH_QUERIES, URL_LIST):

# Stories that run on the android-webview browser.

self.AddStory(SinglePage(

- name='google_%s' % re.sub('\W+', '_', query.lower()),

+ name='google_%s' % re.sub(r'\W+', '_', query.lower()),

url=GOOGLE_SEARCH + urllib.urlencode({'q': query}),

browser_type='android-webview',

phase='on_webview'))

# Stories that run on the browser selected by command line options.

self.AddStory(SinglePage(

- name=re.sub('\W+', '_', url),

+ name=re.sub(r'\W+', '_', url),

url=url,

browser_type='default',

phase='on_chrome'))

« no previous file with comments | « tools/perf/page_sets/__init__.py ('k') | tools/perf/page_sets/memory_top_10_mobile.py » ('j') | no next file with comments »