tools/perf/core/benchmark_finders_unittest.py - Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/core/benchmark_finders_unittest.py

Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Petr's comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/core/benchmark_finders_unittest.py

diff --git a/tools/perf/core/benchmark_finders_unittest.py b/tools/perf/core/benchmark_finders_unittest.py

index b9256122686648973c1e5517d22fb11ad8ae7f46..3043d7fcbcc898608401904192382d9ccb3717eb 100644

--- a/tools/perf/core/benchmark_finders_unittest.py

+++ b/tools/perf/core/benchmark_finders_unittest.py

@@ -23,7 +23,7 @@ class TestGetBenchmarkNamesForFile(unittest.TestCase):

['test_benchmark_1', 'test_benchmark_2', 'test_benchmark_subclass_1',

'test_benchmark_subclass_2'])

- def testListSimpleBenchmarksDefinedInOneFile(self):

+ def testListSimpleBenchmarksDefinedInOneFileComplex(self):

self.assertEquals(

benchmark_finders.GetBenchmarkNamesForFile(

self.top_level_dir,

« no previous file with comments | « tools/perf/benchmarks/benchmark_smoke_unittest.py ('k') | tools/perf/measurements/clock_domain_test.py » ('j') | no next file with comments »