tools/perf/page_sets/__init__.py - Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/page_sets/init.py

Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Petr's comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/perf/measurements/clock_domain_test.py ('k') | tools/perf/page_sets/dual_browser_story.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import inspect	5 import inspect

6 import os	6 import os

7 import sys	7 import sys

8	8

9 from telemetry.core import discover	9 from telemetry.core import discover

10 from telemetry import story	10 from telemetry import story

11	11

12	12

13 # Import all submodules' PageSet classes.	13 # Import all submodules' PageSet classes.

14 start_dir = os.path.dirname(os.path.abspath(__file__))	14 start_dir = os.path.dirname(os.path.abspath(__file__))

15 top_level_dir = os.path.dirname(start_dir)	15 top_level_dir = os.path.dirname(start_dir)

16 base_class = story.StorySet	16 base_class = story.StorySet

	17

17 for cls in discover.DiscoverClasses(	18 for cls in discover.DiscoverClasses(

18 start_dir, top_level_dir, base_class).values():	19 start_dir, top_level_dir, base_class).values():

19 setattr(sys.modules[__name__], cls.__name__, cls)	20 setattr(sys.modules[__name__], cls.__name__, cls)

OLD	NEW

Side by Side Diff: tools/perf/page_sets/__init__.py

Side by Side Diff: tools/perf/page_sets/init.py