tools/perf/measurements/clock_domain_test.py - Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/clock_domain_test.py

Issue 2228413003: [tools/perf] Enable many more lint checks for perf directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Petr's comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/perf/core/benchmark_finders_unittest.py ('k') | tools/perf/page_sets/__init__.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from telemetry import benchmark	5 from telemetry import benchmark

6 from telemetry.testing import tab_test_case	6 from telemetry.testing import tab_test_case

7 from telemetry.timeline import trace_data	7 from telemetry.timeline import trace_data

8 from telemetry.timeline import tracing_config	8 from telemetry.timeline import tracing_config

9	9

10 def GetSyncEvents(trace_part):	10 def GetSyncEvents(trace_part):

(...skipping 20 matching lines...) Expand all Loading...
31	31

32 assert len(chrome_sync) == 1	32 assert len(chrome_sync) == 1

33 assert len(telemetry_sync) == 1	33 assert len(telemetry_sync) == 1

34	34

35 # If Telemetry and Chrome are in the same clock domain, the Chrome sync	35 # If Telemetry and Chrome are in the same clock domain, the Chrome sync

36 # timestamp should be between Telemetry's sync start and end timestamps.	36 # timestamp should be between Telemetry's sync start and end timestamps.

37 ts_telemetry_start = telemetry_sync[0]['args']['issue_ts']	37 ts_telemetry_start = telemetry_sync[0]['args']['issue_ts']

38 ts_chrome = chrome_sync[0]['ts']	38 ts_chrome = chrome_sync[0]['ts']

39 ts_telemetry_end = telemetry_sync[0]['ts']	39 ts_telemetry_end = telemetry_sync[0]['ts']

40 assert ts_chrome > ts_telemetry_start	40 assert ts_chrome > ts_telemetry_start

41 assert ts_telemetry_end > ts_chrome	41 assert ts_telemetry_end > ts_chrome

OLD	NEW