Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2228413002:
tools: Use stl utilities from the base namespace (Closed)
Descriptiontools: Use stl utilities from the base namespace
The utilities in base/stl_util.h have been moved from the global
into the base namespace. This patch updates the call sites accordingly.
No functional changes.
BUG=636301
Committed: https://crrev.com/5ed1e83ba50e4cb2b7f3cd932ff9a97062295ce8
Cr-Commit-Position: refs/heads/master@{#411603}
Patch Set 1 #Patch Set 2 : Rebased #
Messages
Total messages: 19 (14 generated)
The CQ bit was checked by skyostil@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== tools: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 ========== to ========== tools: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 ==========
skyostil@chromium.org changed reviewers: + pasko@chromium.org
PTAL.
lgtm, thank you
The CQ bit was checked by skyostil@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by skyostil@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org Link to the patchset: https://codereview.chromium.org/2228413002/#ps20001 (title: "Rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== tools: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 ========== to ========== tools: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== tools: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 ========== to ========== tools: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 Committed: https://crrev.com/5ed1e83ba50e4cb2b7f3cd932ff9a97062295ce8 Cr-Commit-Position: refs/heads/master@{#411603} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5ed1e83ba50e4cb2b7f3cd932ff9a97062295ce8 Cr-Commit-Position: refs/heads/master@{#411603} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
