Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2228393002: Allow access to scopes of suspended generator objects (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow access to scopes of suspended generator objects The scopes of suspended generators can now be accessed through GeneratorMirror (similar to FrameMirror). BUG=v8:5235 Committed: https://crrev.com/4cff8218b846b0350acdeeb932474f9b43eface5 Cr-Commit-Position: refs/heads/master@{#38530}

Patch Set 1 #

Patch Set 2 : Tolerate invalid GeneratorMirrors #

Patch Set 3 : Remove stale TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -9 lines) Patch
M src/debug/debug-scopes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug-scopes.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/debug/mirrors.js View 9 chunks +39 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 chunks +47 lines, -1 line 0 comments Download
A test/mjsunit/debug-scopes-suspended-generators.js View 1 2 1 chunk +470 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
jgruber
4 years, 4 months ago (2016-08-10 09:15:30 UTC) #8
Yang
On 2016/08/10 09:15:30, jgruber wrote: awesome. lgtm.
4 years, 4 months ago (2016-08-10 10:35:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228393002/40001
4 years, 4 months ago (2016-08-10 10:49:08 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 11:14:29 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 11:14:55 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4cff8218b846b0350acdeeb932474f9b43eface5
Cr-Commit-Position: refs/heads/master@{#38530}

Powered by Google App Engine
This is Rietveld 408576698