Use testharness.js in fast/images/ for border/cmyk tests

Use testharness.js in fast/images/ for border/cmyk tests

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=637859
.

Committed: https://crrev.com/3d22b2bf006e53aa11cbf27561f51962698d188d
Cr-Commit-Position: refs/heads/master@{#411985}

[sivag, 2016-08-10 09:41:22]

Description was changed from

==========
Use testharness.js in fast/images/ - [2].

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=None.
==========

to

==========
Use testharness.js in fast/images/ - [2].

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=None.
==========

[sivag, 2016-08-10 09:41:22]

siva.gunturi@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Srirama, 2016-08-10 14:18:03]

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/images/border.html (right):

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/border.html:5: <script
src="script-tests/border.js"></script>
looks like this is used only here, may be we can expand that file here itself.

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html
(right):

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html:5:
<script src="script-tests/cmyk-jpeg-with-color-profile.js"></script>
ditto

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/images/script-tests/border.js (right):

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/script-tests/border.js:3: {
nit: move the brace to previous line for consistency.

[sivag, 2016-08-10 14:37:12]

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/images/border.html (right):

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/border.html:5: <script
src="script-tests/border.js"></script>
On 2016/08/10 14:18:03, Srirama wrote:
> looks like this is used only here, may be we can expand that file here itself.

Done.

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html
(right):

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html:5:
<script src="script-tests/cmyk-jpeg-with-color-profile.js"></script>
On 2016/08/10 14:18:03, Srirama wrote:
> ditto

Done.

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/images/script-tests/border.js (right):

https://codereview.chromium.org/2228333003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/script-tests/border.js:3: {
On 2016/08/10 14:18:03, Srirama wrote:
> nit: move the brace to previous line for consistency.

Done.

[sivag, 2016-08-10 14:38:01]

siva.gunturi@samsung.com changed reviewers:
+ fs@opera.com

[sivag, 2016-08-10 14:38:01]

siva.gunturi@samsung.com changed reviewers:
+ fs@opera.com

[sivag, 2016-08-10 14:38:21]

@fs, ptal..

[fs, 2016-08-10 17:46:07]

LGTM w/ some nits, but otherwise the same general comments as in the "[1]" CL.

https://codereview.chromium.org/2228333003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html
(right):

https://codereview.chromium.org/2228333003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html:21:
// Read the pixels in the canvas and calculate their avarage values.
Nit: s/avarage/average/

https://codereview.chromium.org/2228333003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html:23:
var data = context.getImageData(0, 0, canvas.width, canvas.height);
Optional: Maybe do getImageData(...).data directly here, and then use
data.length instead of 'pixels'.

https://codereview.chromium.org/2228333003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html:41:

Nit: Drop blank line.

https://codereview.chromium.org/2228333003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html:46:

Ditto.

[sivag, 2016-08-15 16:24:01]

Description was changed from

==========
Use testharness.js in fast/images/ - [2].

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=None.
==========

to

==========
Use testharness.js in fast/images/ for border/cmyk tests

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=None.
==========

[sivag, 2016-08-15 16:39:51]

Description was changed from

==========
Use testharness.js in fast/images/ for border/cmyk tests

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=None.
==========

to

==========
Use testharness.js in fast/images/ for border/cmyk tests

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=637859.
==========

[sivag, 2016-08-15 16:45:55]

https://codereview.chromium.org/2228333003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html
(right):

https://codereview.chromium.org/2228333003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html:21:
// Read the pixels in the canvas and calculate their avarage values.
On 2016/08/10 17:46:07, fs wrote:
> Nit: s/avarage/average/

Done.

https://codereview.chromium.org/2228333003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html:23:
var data = context.getImageData(0, 0, canvas.width, canvas.height);
On 2016/08/10 17:46:07, fs wrote:
> Optional: Maybe do getImageData(...).data directly here, and then use
> data.length instead of 'pixels'.
I left it unchanged.

https://codereview.chromium.org/2228333003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html:41:

On 2016/08/10 17:46:07, fs wrote:
> Nit: Drop blank line.

Done.

https://codereview.chromium.org/2228333003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/images/cmyk-jpeg-with-color-profile.html:46:

On 2016/08/10 17:46:07, fs wrote:
> Ditto.

Done.

[sivag, 2016-08-15 16:46:30]

The CQ bit was checked by siva.gunturi@samsung.com

[sivag, 2016-08-15 16:46:31]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2228333003/#ps60001
(title: "Code changed as per comments.")

[commit-bot: I haz the power, 2016-08-15 16:46:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 18:06:50]

Description was changed from

==========
Use testharness.js in fast/images/ for border/cmyk tests

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=637859.
==========

to

==========
Use testharness.js in fast/images/ for border/cmyk tests

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=637859.
==========

[commit-bot: I haz the power, 2016-08-15 18:06:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-15 18:11:22]

Description was changed from

==========
Use testharness.js in fast/images/ for border/cmyk tests

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=637859.
==========

to

==========
Use testharness.js in fast/images/ for border/cmyk tests

Remove js-test.js and start using testharness.js.
Code refactoring using testharness asserts.

BUG=637859.

Committed: https://crrev.com/3d22b2bf006e53aa11cbf27561f51962698d188d
Cr-Commit-Position: refs/heads/master@{#411985}
==========

[commit-bot: I haz the power, 2016-08-15 18:11:23]

Patchset 4 (id:??) landed as
https://crrev.com/3d22b2bf006e53aa11cbf27561f51962698d188d
Cr-Commit-Position: refs/heads/master@{#411985}