third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp - Issue 2228313002: Make a function to query whether a CSSPropertyID is valid and whether it has a name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

Issue 2228313002: Make a function to query whether a CSSPropertyID is valid and whether it has a name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@asan

Patch Set: Revert spurious change Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_css_property_names.py ('k') | third_party/WebKit/Source/core/css/StylePropertySerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

index 0ab1173dc676ef47fc1df5599cf527d5d57efc55..0d548749ba41b4c0bfa9deb55999c67b490c53a7 100644

--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

@@ -129,7 +129,7 @@ static StringKeyframeEffectModel* createKeyframeEffectModel(

DEFINE_STATIC_LOCAL(SparseHistogram, propertyHistogram,

("WebCore.Animation.CSSProperties"));

for (CSSPropertyID property : specifiedPropertiesForUseCounter) {

- DCHECK_NE(property, CSSPropertyInvalid);

+ DCHECK(isValidCSSPropertyID(property));

propertyHistogram.sample(

UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram(property));

}

@@ -625,7 +625,7 @@ void CSSAnimations::maybeApplyPendingUpdate(Element* element) {

animation->update(TimingUpdateOnDemand);

runningTransition.animation = animation;

m_transitions.set(id, runningTransition);

- DCHECK_NE(id, CSSPropertyInvalid);

+ DCHECK(isValidCSSPropertyID(id));

DEFINE_STATIC_LOCAL(SparseHistogram, propertyHistogram,

("WebCore.Animation.CSSProperties"));