third_party/WebKit/Source/core/frame/Deprecation.cpp - Issue 2228313002: Make a function to query whether a CSSPropertyID is valid and whether it has a name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2228313002: Make a function to query whether a CSSPropertyID is valid and whether it has a name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@asan

Patch Set: Revert incorrect changes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/make_css_property_names.py ('K') | « third_party/WebKit/Source/core/css/StylePropertySerializer.cpp ('k') | third_party/WebKit/Source/core/frame/UseCounter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/Deprecation.cpp

diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp

index 4470ec0a42e279a6216d354380d0b539dd066f07..a71b7e573757192ac5963d0609191df331a3415c 100644

--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp

+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp

@@ -90,15 +90,13 @@ void Deprecation::unmuteForInspector()

void Deprecation::suppress(CSSPropertyID unresolvedProperty)

{

- ASSERT(unresolvedProperty >= firstCSSProperty);

- ASSERT(unresolvedProperty <= lastUnresolvedCSSProperty);

+ DCHECK(isPropertyIDWithName(unresolvedProperty));

m_cssPropertyDeprecationBits.quickSet(unresolvedProperty);

}

bool Deprecation::isSuppressed(CSSPropertyID unresolvedProperty)

{

- ASSERT(unresolvedProperty >= firstCSSProperty);

- ASSERT(unresolvedProperty <= lastUnresolvedCSSProperty);

+ DCHECK(isPropertyIDWithName(unresolvedProperty));

return m_cssPropertyDeprecationBits.quickGet(unresolvedProperty);

}