Remove dead code in spell checker

Remove dead code in spell checker

This patch removes:

1. TextCheckingType and TextCheckingTypeMask, because all their clients have
hard-coded their value to the same constant.

2. WebSpellCheckClient::checkTextOfParagraph() and all its overrides. This
function is in fact dead code, because it can only be called with
|mask == WebTextCheckingTypeGrammar|, but does not do anything when |mask|
does not contain WebTextCheckingTypeSpelling.

3. WebTextCheckingType and WebTextCheckingTypeMask, because their only client
is WebSpellCheckClient::checkTextOfParagraph().

BUG=619452
TEST=n/a; no behavior change

Committed: https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38
Cr-Commit-Position: refs/heads/master@{#411010}

[Xiaocheng, 2016-08-10 02:23:45]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 02:24:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-10 03:57:54]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 03:58:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-10 04:51:17]

Description was changed from

==========
Remove WebTextCheckingType and WebSpellCheckClient::checkTextOfParagraph

BUG=
==========

to

==========
Remove dead code in spell checker

This patch removes:

1. TextCheckingType and TextCheckingTypeMask, because all their clients have
hard-coded their value to the same constant.

2. WebSpellCheckClient::checkTextOfParagraph() and all its overrides. This
function is in fact dead code, because it can only be called with
|mask == WebTextCheckingTypeGrammar|, but does not do anything when |mask|
does not contain WebTextCheckingTypeSpelling.

3. WebTextCheckingType and WebTextCheckingTypeMask, because their only client
is WebSpellCheckClient::checkTextOfParagraph().

BUG=619452
TEST=n/a; no behavior change
==========

[Xiaocheng, 2016-08-10 04:52:00]

xiaochengh@chromium.org changed reviewers:
+ rouslan@chromium.org, tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-08-10 04:52:11]

PTAL.

[Xiaocheng, 2016-08-10 04:57:49]

https://codereview.chromium.org/2228293002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/AssertMatchingEnums.cpp (left):

https://codereview.chromium.org/2228293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/AssertMatchingEnums.cpp:594: // TODO(rouslan):
Remove these comparisons between text-checking and text-decoration enum values
after removing the
To rouslan: I haven't found the deprecated constructors you mentioned. Are they
already gone?

[please use gerrit instead, 2016-08-10 05:16:58]

chrome/renderer/spellchecker/spellcheck_provider.* lgtm

https://codereview.chromium.org/2228293002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/AssertMatchingEnums.cpp (left):

https://codereview.chromium.org/2228293002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/AssertMatchingEnums.cpp:594: // TODO(rouslan):
Remove these comparisons between text-checking and text-decoration enum values
after removing the
On 2016/08/10 04:57:49, Xiaocheng wrote:
> To rouslan: I haven't found the deprecated constructors you mentioned. Are
they
> already gone?

Yes.

[tkent, 2016-08-10 05:59:08]

lgtm

[commit-bot: I haz the power, 2016-08-10 07:04:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 07:04:17]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2016-08-10 07:07:22]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-08-10 07:07:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 08:45:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-10 08:49:03]

Description was changed from

==========
Remove dead code in spell checker

This patch removes:

1. TextCheckingType and TextCheckingTypeMask, because all their clients have
hard-coded their value to the same constant.

2. WebSpellCheckClient::checkTextOfParagraph() and all its overrides. This
function is in fact dead code, because it can only be called with
|mask == WebTextCheckingTypeGrammar|, but does not do anything when |mask|
does not contain WebTextCheckingTypeSpelling.

3. WebTextCheckingType and WebTextCheckingTypeMask, because their only client
is WebSpellCheckClient::checkTextOfParagraph().

BUG=619452
TEST=n/a; no behavior change
==========

to

==========
Remove dead code in spell checker

This patch removes:

1. TextCheckingType and TextCheckingTypeMask, because all their clients have
hard-coded their value to the same constant.

2. WebSpellCheckClient::checkTextOfParagraph() and all its overrides. This
function is in fact dead code, because it can only be called with
|mask == WebTextCheckingTypeGrammar|, but does not do anything when |mask|
does not contain WebTextCheckingTypeSpelling.

3. WebTextCheckingType and WebTextCheckingTypeMask, because their only client
is WebSpellCheckClient::checkTextOfParagraph().

BUG=619452
TEST=n/a; no behavior change

Committed: https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38
Cr-Commit-Position: refs/heads/master@{#411010}
==========

[commit-bot: I haz the power, 2016-08-10 08:49:04]

Patchset 2 (id:??) landed as
https://crrev.com/c66e99411384c332f3fddd1c8114fb8a0bad8e38
Cr-Commit-Position: refs/heads/master@{#411010}