Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 2228273002: Run ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() on Worker thread instead of IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_builder_impl2_thread Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index f24995dffcb498b862b1253665a6b640d85dce9a..a9c4b88851d25ac85752a6a7e292d7f38585c981 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -28,8 +28,7 @@ class ShortcutHelper {
// added depends on the properties in |info|. Calls one of
// InstallWebApkInBackgroundWithSkBitmap, AddWebappInBackgroundWithSkBitmap,
// or AddShortcutInBackgroundWithSkBitmap.
- // Must not be called on the UI thread.
- static void AddToLauncherInBackgroundWithSkBitmap(
+ static void AddToLauncherWithSkBitmap(
content::BrowserContext* browser_context,
const ShortcutInfo& info,
const std::string& webapp_id,
@@ -37,8 +36,7 @@ class ShortcutHelper {
const base::Closure& splash_image_callback);
// Installs WebAPK and adds shortcut to the launcher.
- // Must not be called on the UI thread.
- static void InstallWebApkInBackgroundWithSkBitmap(
+ static void InstallWebApkWithSkBitmap(
content::BrowserContext* browser_context,
const ShortcutInfo& info,
const SkBitmap& icon_bitmap);
@@ -48,16 +46,14 @@ class ShortcutHelper {
// completed. This is necessary as Java will asynchronously create and
// populate a WebappDataStorage object for standalone-capable sites. This must
// exist before the splash image can be stored.
- // Must not be called on the UI thread.
- static void AddWebappInBackgroundWithSkBitmap(
+ static void AddWebappWithSkBitmap(
const ShortcutInfo& info,
const std::string& webapp_id,
const SkBitmap& icon_bitmap,
const base::Closure& splash_image_callback);
// Adds a shortcut which opens in a browser tab to the launcher.
- // Must not be called on the UI thread.
- static void AddShortcutInBackgroundWithSkBitmap(
+ static void AddShortcutWithSkBitmap(
const ShortcutInfo& info,
const SkBitmap& icon_bitmap);
« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.cc ('k') | chrome/browser/android/shortcut_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698