chrome/browser/android/banners/app_banner_infobar_delegate_android.cc - Issue 2228273002: Run ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() on Worker thread instead of IO thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Issue 2228273002: Run ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap() on Worker thread instead of IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('k') | chrome/browser/android/shortcut_helper.h » ('j') | chrome/browser/android/shortcut_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

index 643eb4cae2aeb8bd1c44abd0cfe4658aac31f0ad..b4ac181c405ad5e20618edb58b2ac600a3c51915 100644

--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

@@ -260,12 +260,9 @@ bool AppBannerInfoBarDelegateAndroid::Accept() {

info.UpdateSource(ShortcutInfo::SOURCE_APP_BANNER);

const std::string& uid = base::GenerateGUID();

- content::BrowserThread::PostTask(

- content::BrowserThread::IO, FROM_HERE,

- base::Bind(&ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap,

- web_contents->GetBrowserContext(), info, uid,

- *app_icon_.get(),

- data_fetcher_->FetchWebappSplashScreenImageCallback(uid)));

+ ShortcutHelper::AddToLauncherWithSkBitmap(

+ web_contents->GetBrowserContext(), info, uid, *app_icon_.get(),

+ data_fetcher_->FetchWebappSplashScreenImageCallback(uid));

SendBannerAccepted(web_contents, "web");

return true;