Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: pkg/analyzer/test/generated/non_hint_code_test.dart

Issue 2228233003: Remove false positive from override hint (issue 27046) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/non_hint_code_test.dart
diff --git a/pkg/analyzer/test/generated/non_hint_code_test.dart b/pkg/analyzer/test/generated/non_hint_code_test.dart
index 4ec16403a176138be2b18aa73b166e5368b87f61..16ba3a9cb5a2e4e839ed36038183386bb527b62c 100644
--- a/pkg/analyzer/test/generated/non_hint_code_test.dart
+++ b/pkg/analyzer/test/generated/non_hint_code_test.dart
@@ -488,8 +488,6 @@ class A {
void test_overrideOnNonOverridingField_inInterface() {
Source source = addSource(r'''
-library dart.core;
-const override = null;
class A {
int get a => 0;
void set b(_) {}
@@ -510,8 +508,6 @@ class B implements A {
void test_overrideOnNonOverridingField_inSuperclass() {
Source source = addSource(r'''
-library dart.core;
-const override = null;
class A {
int get a => 0;
void set b(_) {}
@@ -532,8 +528,6 @@ class B extends A {
void test_overrideOnNonOverridingGetter_inInterface() {
Source source = addSource(r'''
-library dart.core;
-const override = null;
class A {
int get m => 0;
}
@@ -548,8 +542,6 @@ class B implements A {
void test_overrideOnNonOverridingGetter_inSuperclass() {
Source source = addSource(r'''
-library dart.core;
-const override = null;
class A {
int get m => 0;
}
@@ -564,8 +556,6 @@ class B extends A {
void test_overrideOnNonOverridingMethod_inInterface() {
Source source = addSource(r'''
-library dart.core;
-const override = null;
class A {
int m() => 0;
}
@@ -580,8 +570,6 @@ class B implements A {
void test_overrideOnNonOverridingMethod_inSuperclass() {
Source source = addSource(r'''
-library dart.core;
-const override = null;
class A {
int m() => 0;
}
@@ -594,10 +582,22 @@ class B extends A {
verify([source]);
}
+ void test_overrideOnNonOverridingMethod_inSuperclass_abstract() {
+ Source source = addSource(r'''
+abstract class A {
+ int m();
+}
+class B extends A {
+ @override
+ int m() => 1;
+}''');
+ computeLibrarySourceErrors(source);
+ assertNoErrors(source);
+ verify([source]);
+ }
+
void test_overrideOnNonOverridingSetter_inInterface() {
Source source = addSource(r'''
-library dart.core;
-const override = null;
class A {
set m(int x) {}
}
@@ -612,8 +612,6 @@ class B implements A {
void test_overrideOnNonOverridingSetter_inSuperclass() {
Source source = addSource(r'''
-library dart.core;
-const override = null;
class A {
set m(int x) {}
}

Powered by Google App Engine
This is Rietveld 408576698