Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2228233002: Volatilize the global store in DummyExport to defeat Clang's optimizer and avoid ICF (Closed)

Created:
4 years, 4 months ago by Reid Kleckner
Modified:
4 years, 4 months ago
Reviewers:
Nico, grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Volatilize the global store in DummyExport to defeat Clang's optimizer and avoid ICF Otherwise this test crashes under ASan while running a corrupted at-exit handler. R=grt@chromium.org,thakis@chromium.org BUG=636157 Committed: https://crrev.com/98b87cf47c62669a1bcd67f0db868c31482605a1 Cr-Commit-Position: refs/heads/master@{#411134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/safe_browsing/incident_reporting/verifier_test/verifier_test_dll.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Reid Kleckner
4 years, 4 months ago (2016-08-10 00:04:04 UTC) #1
Nico
lgtm
4 years, 4 months ago (2016-08-10 01:36:16 UTC) #2
Nico
On 2016/08/10 01:36:16, Nico (away until Mon Aug 22) wrote: > lgtm grt: see bug ...
4 years, 4 months ago (2016-08-10 01:36:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228233002/1
4 years, 4 months ago (2016-08-10 14:29:42 UTC) #5
grt (UTC plus 2)
lgtm
4 years, 4 months ago (2016-08-10 14:39:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/49443)
4 years, 4 months ago (2016-08-10 15:12:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228233002/1
4 years, 4 months ago (2016-08-10 20:20:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 20:25:26 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 20:28:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98b87cf47c62669a1bcd67f0db868c31482605a1
Cr-Commit-Position: refs/heads/master@{#411134}

Powered by Google App Engine
This is Rietveld 408576698