Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2228213002: EME: Specify the correct size for PSSH boxes in tests (Closed)

Created:
4 years, 4 months ago by ddorwin
Modified:
4 years, 4 months ago
Reviewers:
jrummell
CC:
chromium-reviews, blink-reviews, eme-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify the correct size for PSSH boxes in tests Size 0 is unrealistic. See https://github.com/w3c/web-platform-tests/issues/3430. Committed: https://crrev.com/c13a1d8e190dd8f433480f17eaba4fcb288c52ae Cr-Commit-Position: refs/heads/master@{#411184}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M media/cdm/cdm_adapter_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/cdm/cenc_utils_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-generate-request-disallowed-input.html View 1 chunk +2 lines, -2 lines 1 comment Download
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-utils.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
ddorwin
I only searched for the Common System SystemID; there may be other PSSH boxes I ...
4 years, 4 months ago (2016-08-09 23:32:24 UTC) #2
jrummell
lgtm
4 years, 4 months ago (2016-08-10 21:53:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228213002/1
4 years, 4 months ago (2016-08-10 23:18:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 23:36:52 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c13a1d8e190dd8f433480f17eaba4fcb288c52ae Cr-Commit-Position: refs/heads/master@{#411184}
4 years, 4 months ago (2016-08-10 23:39:55 UTC) #14
ddorwin
4 years, 4 months ago (2016-08-11 00:16:18 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2228213002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-generate-request-disallowed-input.html
(right):

https://codereview.chromium.org/2228213002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-generate-request-disallowed-input.html:75:
0x00, 0x00, 0x00, 0x20,                          // size = 0
The comment was not updated. This is fixed in
https://codereview.chromium.org/2237673002.

Powered by Google App Engine
This is Rietveld 408576698