Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2228203002: constexpr infinity (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
hal.canary, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

constexpr infinity ~/skia (inf) $ nm /tmp/rel/obj/src/core/libskia.SkLiteDL.o | grep GLOBAL__sub <nothing> TBR=halcanary@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2228203002 Committed: https://skia.googlesource.com/skia/+/cd8864111d191be4db42a478d6bf877eb50277a7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/core/SkLiteDL.cpp View 1 chunk +3 lines, -2 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228203002/1
4 years, 4 months ago (2016-08-09 23:10:19 UTC) #3
mtklein_C
4 years, 4 months ago (2016-08-09 23:10:31 UTC) #4
mtklein_C
If this doesn't work, I'll just reinterpret_cast a uint32_t constant (0x7f800000).
4 years, 4 months ago (2016-08-09 23:11:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/cd8864111d191be4db42a478d6bf877eb50277a7
4 years, 4 months ago (2016-08-09 23:37:51 UTC) #7
hal.canary
lgtm
4 years, 4 months ago (2016-08-10 00:47:10 UTC) #8
reed1
4 years, 4 months ago (2016-08-10 11:53:17 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2228203002/diff/1/src/core/SkLiteDL.cpp
File src/core/SkLiteDL.cpp (right):

https://codereview.chromium.org/2228203002/diff/1/src/core/SkLiteDL.cpp#newco...
src/core/SkLiteDL.cpp:20: static const SkRect kUnset = {(SkScalar)INFINITY,
0,0,0};
If this is better, should we use this for our definition?

Powered by Google App Engine
This is Rietveld 408576698