[Offline pages] Download UI: Adding Download Service Delegate for notifications

[Offline pages] Download UI: Adding Download Service Delegate for notifications

Extracts an interface through which DownloadNotificationService communicates
with DownloadManagerService, so that offline page related download items
can be handled using the same interface.

BUG=630817
Committed: https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6
Cr-Commit-Position: refs/heads/master@{#411988}

[fgorski, 2016-08-09 22:31:40]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 22:32:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-08-09 22:33:45]

fgorski@chromium.org changed reviewers:
+ dimich@google.com, qinmin@chromium.org

[fgorski, 2016-08-09 22:33:47]

This is second prep patch for hooking up offline page related downloads to
notification service.

[commit-bot: I haz the power, 2016-08-10 00:50:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 00:50:51]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-08-11 17:50:02]

On 2016/08/10 00:50:51, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

ping

[fgorski, 2016-08-12 17:35:18]

Description was changed from

==========
[Offline pages] Download UI: Adding Download Service Delegate for notifications

Extracts an interface through which DownloadNotificationService communicates
with DownloadManagerService, so that offline page related download items
can be handled using the same interface.

BUG=630817
==========

to

==========
[Offline pages] Download UI: Adding Download Service Delegate for notifications

Extracts an interface through which DownloadNotificationService communicates
with DownloadManagerService, so that offline page related download items
can be handled using the same interface.

BUG=630817
==========

[fgorski, 2016-08-12 17:35:18]

fgorski@chromium.org changed reviewers:
+ dimich@chromium.org
- dimich@google.com

[qinmin, 2016-08-12 18:31:17]

lgtm

[Dmitry Titov, 2016-08-12 19:54:30]

lgtm with a nit:

https://codereview.chromium.org/2228193002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java
(right):

https://codereview.chromium.org/2228193002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java:30:
void resumeDownload(DownloadItem item, boolean hasUserGesture);
Please add TODO on removing dependency on DownloadItem here.

[fgorski, 2016-08-12 20:06:10]

Added a TODO

[fgorski, 2016-08-12 20:06:13]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-08-12 20:06:14]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
dimich@chromium.org
Link to the patchset: https://codereview.chromium.org/2228193002/#ps20001
(title: "Adding a TODO")

[commit-bot: I haz the power, 2016-08-12 20:06:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 20:32:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:32:16]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[fgorski, 2016-08-15 17:13:42]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-08-15 17:14:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 18:09:48]

Description was changed from

==========
[Offline pages] Download UI: Adding Download Service Delegate for notifications

Extracts an interface through which DownloadNotificationService communicates
with DownloadManagerService, so that offline page related download items
can be handled using the same interface.

BUG=630817
==========

to

==========
[Offline pages] Download UI: Adding Download Service Delegate for notifications

Extracts an interface through which DownloadNotificationService communicates
with DownloadManagerService, so that offline page related download items
can be handled using the same interface.

BUG=630817
==========

[commit-bot: I haz the power, 2016-08-15 18:09:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-15 18:15:42]

Description was changed from

==========
[Offline pages] Download UI: Adding Download Service Delegate for notifications

Extracts an interface through which DownloadNotificationService communicates
with DownloadManagerService, so that offline page related download items
can be handled using the same interface.

BUG=630817
==========

to

==========
[Offline pages] Download UI: Adding Download Service Delegate for notifications

Extracts an interface through which DownloadNotificationService communicates
with DownloadManagerService, so that offline page related download items
can be handled using the same interface.

BUG=630817

Committed: https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6
Cr-Commit-Position: refs/heads/master@{#411988}
==========

[commit-bot: I haz the power, 2016-08-15 18:15:44]

Patchset 2 (id:??) landed as
https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6
Cr-Commit-Position: refs/heads/master@{#411988}