Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2228193002: [Offline pages] Download UI: Adding Download Service Delegate for notifications (Closed)

Created:
4 years, 4 months ago by fgorski
Modified:
4 years, 4 months ago
Reviewers:
qinmin, Dmitry Titov
CC:
chromium-reviews, asanka, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Download UI: Adding Download Service Delegate for notifications Extracts an interface through which DownloadNotificationService communicates with DownloadManagerService, so that offline page related download items can be handled using the same interface. BUG=630817 Committed: https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6 Cr-Commit-Position: refs/heads/master@{#411988}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Adding a TODO #

Messages

Total messages: 23 (13 generated)
fgorski
This is second prep patch for hooking up offline page related downloads to notification service.
4 years, 4 months ago (2016-08-09 22:33:47 UTC) #4
fgorski
On 2016/08/10 00:50:51, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 4 months ago (2016-08-11 17:50:02 UTC) #7
qinmin
lgtm
4 years, 4 months ago (2016-08-12 18:31:17 UTC) #10
Dmitry Titov
lgtm with a nit: https://codereview.chromium.org/2228193002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java (right): https://codereview.chromium.org/2228193002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java#newcode30 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadServiceDelegate.java:30: void resumeDownload(DownloadItem item, boolean hasUserGesture); ...
4 years, 4 months ago (2016-08-12 19:54:30 UTC) #11
fgorski
Added a TODO
4 years, 4 months ago (2016-08-12 20:06:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228193002/20001
4 years, 4 months ago (2016-08-12 20:06:37 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/111830)
4 years, 4 months ago (2016-08-12 20:32:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228193002/20001
4 years, 4 months ago (2016-08-15 17:14:00 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 18:09:49 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:15:44 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e2c2dd91f4e3f52aab75454aa34b2b6df5ba1e6
Cr-Commit-Position: refs/heads/master@{#411988}

Powered by Google App Engine
This is Rietveld 408576698