Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2228183002: Updates to icons for Ash material design system tray (Closed)

Created:
4 years, 4 months ago by tdanderson
Modified:
4 years, 4 months ago
Reviewers:
James Cook, Evan Stade
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates to icons for Ash material design system tray Updates the remaining icons used for the Ash material design system tray (and their system menu counterparts): * Accessibility * Cast * Screen capture BUG=625690, 606817, 632026 TEST=manual Committed: https://crrev.com/26b0e5bdda021c14f2878c1bde5a400ad60fbe7f Cr-Commit-Position: refs/heads/master@{#411374}

Patch Set 1 #

Patch Set 2 : gfx namespace #

Total comments: 5

Patch Set 3 : const ref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -95 lines) Patch
M ash/common/system/cast/tray_cast.cc View 1 2 6 chunks +30 lines, -7 lines 0 comments Download
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/network/tray_network.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/network/tray_sms.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M ash/common/system/chromeos/network/tray_vpn.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/screen_security/screen_capture_tray_item.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_share_tray_item.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item.h View 3 chunks +1 line, -3 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item.cc View 4 chunks +23 lines, -9 lines 0 comments Download
M ash/common/system/ime/tray_ime_chromeos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/tray_item_more.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/tray_item_more.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/tray_notification_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/tray_accessibility.cc View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M ui/gfx/vector_icons/system_menu_accessibility.icon View 1 chunk +18 lines, -19 lines 0 comments Download
A ui/gfx/vector_icons/system_menu_accessibility.1x.icon View 1 chunk +25 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/system_menu_cast.icon View 1 chunk +47 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/system_menu_cast.1x.icon View 1 chunk +47 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/system_menu_screen_share.icon View 1 chunk +28 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/system_menu_screen_share.1x.icon View 1 chunk +28 lines, -0 lines 0 comments Download
M ui/gfx/vector_icons/system_tray_accessibility.icon View 1 chunk +16 lines, -15 lines 0 comments Download
M ui/gfx/vector_icons/system_tray_accessibility.1x.icon View 1 chunk +17 lines, -14 lines 0 comments Download
A ui/gfx/vector_icons/system_tray_cast.icon View 1 chunk +55 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/system_tray_cast.1x.icon View 1 chunk +45 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/system_tray_screen_share.icon View 1 chunk +28 lines, -0 lines 0 comments Download
A ui/gfx/vector_icons/system_tray_screen_share.1x.icon View 1 chunk +28 lines, -0 lines 0 comments Download
M ui/gfx/vector_icons_sources.gypi View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
tdanderson
James and Evan, can you please take a look?
4 years, 4 months ago (2016-08-09 22:43:27 UTC) #6
James Cook
LGTM with a question. Please be sure Evan is happy with it too. https://codereview.chromium.org/2228183002/diff/20001/ash/common/system/chromeos/screen_security/screen_tray_item.h File ...
4 years, 4 months ago (2016-08-09 23:55:02 UTC) #7
tdanderson
https://chromiumcodereview.appspot.com/2228183002/diff/20001/ui/gfx/vector_icons/system_tray_accessibility.icon File ui/gfx/vector_icons/system_tray_accessibility.icon (right): https://chromiumcodereview.appspot.com/2228183002/diff/20001/ui/gfx/vector_icons/system_tray_accessibility.icon#newcode6 ui/gfx/vector_icons/system_tray_accessibility.icon:6: MOVE_TO, 16, 11.44f, On 2016/08/09 23:55:02, James Cook wrote: ...
4 years, 4 months ago (2016-08-10 12:28:07 UTC) #10
Evan Stade
lgtm https://chromiumcodereview.appspot.com/2228183002/diff/20001/ash/common/system/cast/tray_cast.cc File ash/common/system/cast/tray_cast.cc (right): https://chromiumcodereview.appspot.com/2228183002/diff/20001/ash/common/system/cast/tray_cast.cc#newcode96 ash/common/system/cast/tray_cast.cc:96: SetImage(&image_md); can you make TrayItemMore support SetImage with ...
4 years, 4 months ago (2016-08-10 22:07:56 UTC) #11
tdanderson
https://codereview.chromium.org/2228183002/diff/20001/ash/common/system/cast/tray_cast.cc File ash/common/system/cast/tray_cast.cc (right): https://codereview.chromium.org/2228183002/diff/20001/ash/common/system/cast/tray_cast.cc#newcode96 ash/common/system/cast/tray_cast.cc:96: SetImage(&image_md); On 2016/08/10 22:07:56, Evan Stade wrote: > can ...
4 years, 4 months ago (2016-08-11 16:31:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228183002/40001
4 years, 4 months ago (2016-08-11 16:32:49 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-11 18:10:30 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 18:14:15 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/26b0e5bdda021c14f2878c1bde5a400ad60fbe7f
Cr-Commit-Position: refs/heads/master@{#411374}

Powered by Google App Engine
This is Rietveld 408576698