Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2134)

Unified Diff: build/config/mac/BUILD.gn

Issue 2228143002: Force rebuild of everything if the version of Xcode changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/BUILD.gn
diff --git a/build/config/mac/BUILD.gn b/build/config/mac/BUILD.gn
index ec66a15ce5ec15ca9bcf66f5579d994ce5862dcf..84180e6a65af14b4c9f887498bb8463365b4ed41 100644
--- a/build/config/mac/BUILD.gn
+++ b/build/config/mac/BUILD.gn
@@ -3,11 +3,14 @@
# found in the LICENSE file.
import("//build/config/sysroot.gni")
+import("//build/config/mac/mac_sdk.gni")
+import("//build/config/mac/symbols.gni")
+
if (is_ios) {
+ # This needs to be imported after mac_sdk.gni as it overrides some of the
+ # variables defined by it.
Dirk Pranke 2016/08/09 19:55:48 Told ya! :). We should modify ios_sdk.gni to eith
import("//build/config/ios/ios_sdk.gni")
}
-import("//build/config/mac/mac_sdk.gni")
-import("//build/config/mac/symbols.gni")
# This is included by reference in the //build/config/compiler config that
# is applied to all targets. It is here to separate out the logic.
@@ -40,6 +43,11 @@ config("compiler") {
]
}
+ # This is here so that all files get recompiled after an Xcode update.
+ # (defines are passed via the command line, and build system rebuild things
+ # when their commandline changes). Nothing should ever read this define.
+ defines = [ "CR_XCODE_VERSION=$xcode_version" ]
+
asmflags = common_mac_flags
cflags = common_mac_flags
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698