Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2228143002:
Force rebuild of everything if the version of Xcode changes. (Closed)
|
Created:
4 years, 4 months ago by sdefresne Modified:
4 years, 4 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionForce rebuild of everything if the version of Xcode changes.
BUG=636031
Committed: https://crrev.com/64cd47fc5002365b42d3abe6d8381f5bb0dfcae1
Cr-Commit-Position: refs/heads/master@{#411491}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 17 (9 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
sdefresne@chromium.org changed reviewers: + dpranke@chromium.org
Please take a look. There is no need for a check of the SDK version since it is already part of the command-line via the -isysroot flag.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm. The change suggested below can/should be in a different CL. https://codereview.chromium.org/2228143002/diff/1/build/config/mac/BUILD.gn File build/config/mac/BUILD.gn (right): https://codereview.chromium.org/2228143002/diff/1/build/config/mac/BUILD.gn#n... build/config/mac/BUILD.gn:11: # variables defined by it. Told ya! :). We should modify ios_sdk.gni to either include mac_sdk.gni, or split the common stuff out into an xcode.gni or something. Right now, it's not obvious that both files are modifying a shared variable.
On 2016/08/09 19:55:49, Dirk Pranke wrote: > lgtm. The change suggested below can/should be in a different CL. > > https://codereview.chromium.org/2228143002/diff/1/build/config/mac/BUILD.gn > File build/config/mac/BUILD.gn (right): > > https://codereview.chromium.org/2228143002/diff/1/build/config/mac/BUILD.gn#n... > build/config/mac/BUILD.gn:11: # variables defined by it. > Told ya! :). > > We should modify ios_sdk.gni to either include mac_sdk.gni, or split the common > stuff out into an xcode.gni or something. Right now, it's not obvious that both > files are modifying a shared variable. This is tracked by https://bugs.chromium.org/p/chromium/issues/detail?id=635745.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Force rebuild of everything if the version of Xcode changes. BUG=636031 ========== to ========== Force rebuild of everything if the version of Xcode changes. BUG=636031 Committed: https://crrev.com/64cd47fc5002365b42d3abe6d8381f5bb0dfcae1 Cr-Commit-Position: refs/heads/master@{#411491} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/64cd47fc5002365b42d3abe6d8381f5bb0dfcae1 Cr-Commit-Position: refs/heads/master@{#411491} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
