Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/perf/page_sets/system_health/loading_stories.py

Issue 2228103002: [system-health] Add support for disabling individual stories on individual platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/system_health/loading_stories.py
diff --git a/tools/perf/page_sets/system_health/loading_stories.py b/tools/perf/page_sets/system_health/loading_stories.py
index 9db0b955a56285d020dd8288334f03b8a9c7ad09..b24eacf00f01dcd582da0ead0802aeea6e6cca8b 100644
--- a/tools/perf/page_sets/system_health/loading_stories.py
+++ b/tools/perf/page_sets/system_health/loading_stories.py
@@ -8,6 +8,8 @@ from page_sets.system_health import system_health_story
from page_sets.login_helpers import dropbox_login
from page_sets.login_helpers import google_login
+from telemetry import decorators
+
class _LoadingStory(system_health_story.SystemHealthStory):
"""Abstract base class for single-page System Health user stories."""
@@ -80,14 +82,14 @@ class LoadTwitterStory(_LoadingStory):
URL = 'https://www.twitter.com/nasa'
+# Due to the deterministic date injected by WPR (February 2008), the cookie set
+# by https://vk.com immediately expires, so the page keeps refreshing
+# indefinitely on mobile
+# (see https://github.com/chromium/web-page-replay/issues/71).
+@decorators.Disabled('android')
class LoadVkStory(_LoadingStory):
NAME = 'load:social:vk'
URL = 'https://vk.com/sbeatles'
- # Due to the deterministic date injected by WPR (February 2008), the cookie
- # set by https://vk.com immediately expires, so the page keeps refreshing
- # indefinitely on mobile
- # (see https://github.com/chromium/web-page-replay/issues/71).
- SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
class LoadInstagramStory(_LoadingStory):
@@ -163,7 +165,7 @@ class LoadRedditMobileStory(_LoadingStory):
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
-class LoadSohuStory(_LoadingStory):
+class LoadSohuMobileStory(_LoadingStory):
NAME = 'load:news:sohu'
# Using "https://" leads to missing images and scripts on mobile (due to
# mixed content).
@@ -256,13 +258,13 @@ class LoadFacebookPhotosMobileStory(_LoadingStory):
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
+# Recording currently does not work. The page gets stuck in the theater viewer.
+@decorators.Disabled('all')
class LoadFacebookPhotosDesktopStory(_LoadingStory):
NAME = 'load:media:facebook_photos'
URL = (
'https://www.facebook.com/rihanna/photos/a.207477806675.138795.10092511675/10153911739606676/?type=3&theater')
- # Recording currently does not work. The page gets stuck in the
- # theater viewer.
- SUPPORTED_PLATFORMS = platforms.NO_PLATFORMS
+ SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
################################################################################
@@ -389,12 +391,10 @@ class LoadMiniclipStory(_LoadingStory):
NAME = 'load:games:miniclip'
# Using "https://" causes "404 Not Found" during WPR recording.
URL = 'http://www.miniclip.com/games/en/'
- # Desktop only (requires Flash).
- SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
+ SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY # Requires Flash.
class LoadAlphabettyStory(_LoadingStory):
NAME = 'load:games:alphabetty'
URL = 'https://king.com/play/alphabetty'
- # Desktop only (requires Flash).
- SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
+ SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY # Requires Flash.

Powered by Google App Engine
This is Rietveld 408576698