tools/perf/page_sets/system_health/loading_stories.py - Issue 2228103002: [system-health] Add support for disabling individual stories on individual platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/system_health/loading_stories.py

Issue 2228103002: [system-health] Add support for disabling individual stories on individual platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use possible_browser instead of browser Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/page_sets/system_health/browsing_stories.py ('k') | tools/perf/page_sets/system_health/platforms.py » ('j') | tools/perf/page_sets/system_health/platforms.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/page_sets/system_health/loading_stories.py

diff --git a/tools/perf/page_sets/system_health/loading_stories.py b/tools/perf/page_sets/system_health/loading_stories.py

index 9db0b955a56285d020dd8288334f03b8a9c7ad09..eae99f9b2fbeaf3b4a2f66685b4a1c9402ac815c 100644

--- a/tools/perf/page_sets/system_health/loading_stories.py

+++ b/tools/perf/page_sets/system_health/loading_stories.py

@@ -163,7 +163,7 @@ class LoadRedditMobileStory(_LoadingStory):

SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY

-class LoadSohuStory(_LoadingStory):

+class LoadSohuMobileStory(_LoadingStory):

NAME = 'load:news:sohu'

# Using "https://" leads to missing images and scripts on mobile (due to

# mixed content).

@@ -389,12 +389,10 @@ class LoadMiniclipStory(_LoadingStory):

NAME = 'load:games:miniclip'

# Using "https://" causes "404 Not Found" during WPR recording.

URL = 'http://www.miniclip.com/games/en/'

- # Desktop only (requires Flash).

- SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY

+ SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY # Requires Flash.

class LoadAlphabettyStory(_LoadingStory):

NAME = 'load:games:alphabetty'

URL = 'https://king.com/play/alphabetty'

- # Desktop only (requires Flash).

- SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY

+ SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY # Requires Flash.