tools/perf/page_sets/system_health/platforms.py - Issue 2228103002: [system-health] Add support for disabling individual stories on individual platforms

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/page_sets/system_health/platforms.py

Issue 2228103002: [system-health] Add support for disabling individual stories on individual platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use possible_browser instead of browser Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 DESKTOP = 'desktop'	5 DESKTOP = 'desktop'

6 MOBILE = 'mobile'	6 MOBILE = 'mobile'

7	7

8 ALL_PLATFORMS = frozenset({DESKTOP, MOBILE})	8 ALL_PLATFORMS = frozenset({DESKTOP, MOBILE})

	9

	10 # Use the constants below to mark on which platforms the story has WPR

	11 # recordings. To disable a story (e.g. because it crashes or takes too long),

	12 # use @decorators.Disabled instead.

9 DESKTOP_ONLY = frozenset({DESKTOP})	13 DESKTOP_ONLY = frozenset({DESKTOP})

10 MOBILE_ONLY = frozenset({MOBILE})	14 MOBILE_ONLY = frozenset({MOBILE})

11 # This is used for disabling a story on all platforms.

12 NO_PLATFORMS = frozenset()	15 NO_PLATFORMS = frozenset()
	nednguyen 2016/09/08 19:31:16 Why do you add this back? I thought your decision Why do you add this back? I thought your decision was removing this is right :-) petrcermak 2016/09/09 09:34:09 Good question. The reason is that it needs to be u Show quoted text On 2016/09/08 19:31:16, nednguyen wrote: > Why do you add this back? I thought your decision was removing this is right :-) Good question. The reason is that it needs to be used for stories which don't have a WPR recording (e.g. FacebookPhotosDesktopStory in browsing_stories.py). If I just used @decorators.Disabled('all') on the story, the benchmark would fail because of "missing WPR archive" (even though the story would never actually run). Maybe the story_runner logic could be updated to handle such cases properly, but it might might be difficult in the general case (shared_state.CanRun() can depend on the current state of things, so it might not be possible to tell upfront if a story will run; downloading the WPR archives on demand could, on the other hand, add noise to benchmarks which don't tear down the browser between individual stories) and is probably not be worth the effort.
OLD	NEW

« no previous file with comments | « tools/perf/page_sets/system_health/loading_stories.py ('k') | tools/perf/page_sets/system_health/searching_stories.py » ('j') | no next file with comments »