Generate default AP stream for circle annotation.

Generate default AP stream for circle annotation.

This patch generates a default AP stream for circle annotation so that
circle annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to 71d1f22 to test circle annotations.

BUG=62625
Committed: https://pdfium.googlesource.com/pdfium/+/e7107f48ddb9309e1664d84ec360ce06ec3201e2

[jaepark, 2016-08-09 17:49:24]

jaepark@google.com changed reviewers:
+ thestig@chromium.org

[jaepark, 2016-08-09 17:49:25]

Need to roll DEPS after landing test cases
(https://codereview.chromium.org/2225413003/).

[Lei Zhang, 2016-08-09 17:59:02]

lgtm with DEPS roll.

https://codereview.chromium.org/2228093002/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2228093002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:656: // |fL| is precalculated approximate value
of 4 * tan((3.14  / 2) / 4) / 3,
There's an extra space after 3.14.

https://codereview.chromium.org/2228093002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:682: bool bIsFillRect = pInteriorColor &&
(pInteriorColor->GetCount() > 0);
Use !IsEmpty() instead of GetCount() > 0?

[jaepark, 2016-08-09 18:11:18]

Description was changed from

==========
Generate default AP stream for circle annotation.

This patch generates a default AP stream for circle annotation so that
circle annotations without AP stream can be displayed.

BUG=62625
==========

to

==========
Generate default AP stream for circle annotation.

This patch generates a default AP stream for circle annotation so that
circle annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to 71d1f22 to test circle annotations.

BUG=62625
==========

[jaepark, 2016-08-09 18:11:55]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 18:11:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 18:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 18:18:47]

Dry run: Try jobs failed on following builders:
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/1609)

[jaepark, 2016-08-09 18:25:16]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 18:25:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 18:38:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 18:38:04]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-09 18:39:46]

https://codereview.chromium.org/2228093002/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2228093002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:656: // |fL| is precalculated approximate value
of 4 * tan((3.14  / 2) / 4) / 3,
On 2016/08/09 17:59:02, Lei Zhang wrote:
> There's an extra space after 3.14.

Done.

https://codereview.chromium.org/2228093002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:682: bool bIsFillRect = pInteriorColor &&
(pInteriorColor->GetCount() > 0);
On 2016/08/09 17:59:02, Lei Zhang wrote:
> Use !IsEmpty() instead of GetCount() > 0?

Done.

https://codereview.chromium.org/2228093002/diff/40001/core/fpdfdoc/cpvt_gener...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2228093002/diff/40001/core/fpdfdoc/cpvt_gener...
core/fpdfdoc/cpvt_generateap.cpp:659: const FX_FLOAT fL = 0.5523f;
Fixed windows build.

[jaepark, 2016-08-09 18:40:37]

The CQ bit was checked by jaepark@google.com

[jaepark, 2016-08-09 18:40:37]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2228093002/#ps40001
(title: "Generate default AP stream for circle annotation.")

[commit-bot: I haz the power, 2016-08-09 18:40:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 18:41:02]

Description was changed from

==========
Generate default AP stream for circle annotation.

This patch generates a default AP stream for circle annotation so that
circle annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to 71d1f22 to test circle annotations.

BUG=62625
==========

to

==========
Generate default AP stream for circle annotation.

This patch generates a default AP stream for circle annotation so that
circle annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to 71d1f22 to test circle annotations.

BUG=62625

Committed:
https://pdfium.googlesource.com/pdfium/+/e7107f48ddb9309e1664d84ec360ce06ec32...
==========

[commit-bot: I haz the power, 2016-08-09 18:41:03]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/e7107f48ddb9309e1664d84ec360ce06ec32...