Make API signature based only on unlinked data.

Make API signature based only on unlinked data.

Note that this is safe because linked data can be fully derived from
unlinked data.

This should make it more useful for the PubSummaryManager, which only
stores unlinked data at the moment.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/1229cb7ee92aa7adae283a9af4d4da0082c029e9

[Paul Berry, 2016-08-09 17:02:42]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-08-09 17:12:36]

LGTM

https://codereview.chromium.org/2228083002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/2228083002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:251: for (String unitUri in
_unlinkedUnitUris.toList()..sort()) {
It's probably equivalent, but if we ask values from _unlinkedUnitMap, maybe we
should get keys also from it.

[Paul Berry, 2016-08-09 17:18:02]

https://codereview.chromium.org/2228083002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/summarize_elements.dart (right):

https://codereview.chromium.org/2228083002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/summarize_elements.dart:251: for (String unitUri in
_unlinkedUnitUris.toList()..sort()) {
On 2016/08/09 17:12:36, scheglov wrote:
> It's probably equivalent, but if we ask values from _unlinkedUnitMap, maybe we
> should get keys also from it.

Done.

[Paul Berry, 2016-08-09 17:18:42]

Description was changed from

==========
Make API signature based only on unlinked data.

Note that this is safe because linked data can be fully derived from
unlinked data.

This should make it more useful for the PubSummaryManager, which only
stores unlinked data at the moment.
==========

to

==========
Make API signature based only on unlinked data.

Note that this is safe because linked data can be fully derived from
unlinked data.

This should make it more useful for the PubSummaryManager, which only
stores unlinked data at the moment.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1229cb7ee92aa7adae283a9af4d4da0082c029e9
==========

[Paul Berry, 2016-08-09 17:18:44]

Committed patchset #1 (id:1) manually as
1229cb7ee92aa7adae283a9af4d4da0082c029e9 (presubmit successful).