Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2228073002: [wasm] serialization: updated external APIs. (Closed)

Created:
4 years, 4 months ago by Mircea Trofin
Modified:
4 years, 4 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] serialization: updated external APIs. We only need these external v8 APIs to expose serialization externally, so bypassed having an internal layer for now. BUG=v8:5072 Committed: https://crrev.com/d29bb4bfab5775e1922a367c872b9ef1b5e5a812 Cr-Commit-Position: refs/heads/master@{#38516}

Patch Set 1 #

Patch Set 2 : [wasm] serialization: updated external APIs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -40 lines) Patch
M include/v8.h View 1 3 chunks +20 lines, -0 lines 0 comments Download
M src/api.cc View 1 5 chunks +41 lines, -1 line 0 comments Download
M src/objects.h View 1 2 chunks +0 lines, -21 lines 0 comments Download
M src/objects.cc View 1 2 chunks +1 line, -12 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mircea Trofin
4 years, 4 months ago (2016-08-10 03:26:35 UTC) #5
bradnelson
lgtm
4 years, 4 months ago (2016-08-10 06:33:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228073002/20001
4 years, 4 months ago (2016-08-10 06:33:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 06:35:34 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 06:35:50 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d29bb4bfab5775e1922a367c872b9ef1b5e5a812
Cr-Commit-Position: refs/heads/master@{#38516}

Powered by Google App Engine
This is Rietveld 408576698