Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 222803002: arm64_make script changes (Closed)

Created:
6 years, 8 months ago by hal.canary
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

arm64_make script changes TODO: Call this script from the bots with command sh -x arm64_make Motivation: This will give the logs more complete information about what the scripts are doing. NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14032

Patch Set 1 : AnotherPatchSet #

Total comments: 4

Patch Set 2 : AnotherPatchSet #

Patch Set 3 : AnotherPatchSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M platform_tools/barelinux/bin/arm64_make View 2 chunks +3 lines, -1 line 0 comments Download
M platform_tools/barelinux/bin/barelinux_make View 1 2 3 chunks +11 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hal.canary
PTAL
6 years, 8 months ago (2014-04-02 19:45:43 UTC) #1
mtklein
lgtm https://codereview.chromium.org/222803002/diff/20001/platform_tools/barelinux/bin/barelinux_make File platform_tools/barelinux/bin/barelinux_make (right): https://codereview.chromium.org/222803002/diff/20001/platform_tools/barelinux/bin/barelinux_make#newcode63 platform_tools/barelinux/bin/barelinux_make:63: if ! test "$SKIA_OUT"; then export SKIA_OUT=${SKIA_OUT-"${SKIA_SRC_DIR}/out/barelinux"} https://codereview.chromium.org/222803002/diff/20001/platform_tools/barelinux/bin/barelinux_make#newcode67 ...
6 years, 8 months ago (2014-04-02 20:05:31 UTC) #2
hal.canary
https://codereview.chromium.org/222803002/diff/20001/platform_tools/barelinux/bin/barelinux_make File platform_tools/barelinux/bin/barelinux_make (right): https://codereview.chromium.org/222803002/diff/20001/platform_tools/barelinux/bin/barelinux_make#newcode63 platform_tools/barelinux/bin/barelinux_make:63: if ! test "$SKIA_OUT"; then On 2014/04/02 20:05:32, mtklein ...
6 years, 8 months ago (2014-04-02 20:07:20 UTC) #3
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 8 months ago (2014-04-02 20:09:04 UTC) #4
hal.canary
The CQ bit was unchecked by halcanary@google.com
6 years, 8 months ago (2014-04-02 20:09:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/222803002/40001
6 years, 8 months ago (2014-04-02 20:09:07 UTC) #6
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 8 months ago (2014-04-02 20:12:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/222803002/60001
6 years, 8 months ago (2014-04-02 20:12:17 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 20:12:29 UTC) #9
Message was sent while issue was closed.
Change committed as 14032

Powered by Google App Engine
This is Rietveld 408576698