Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 2228023002: [KeyedLoadIC] Refactor typed array loading code (Closed)

Created:
4 years, 4 months ago by Jakob Kummerow
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@reland-klic-elements
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[KeyedLoadIC] Refactor typed array loading code This is just reformatting, no change in behavior. Committed: https://crrev.com/8e8bfb5d72d17d1e6ec0954a8a867a4940111e47 Cr-Commit-Position: refs/heads/master@{#38539}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -60 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +64 lines, -60 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
Jakob Kummerow
This is the reformatting we discussed. Which version do you like better, new or old?
4 years, 4 months ago (2016-08-09 15:11:20 UTC) #3
Toon Verwaest
I have a slight preference for the newer. Perhaps we should ask a stub guru ...
4 years, 4 months ago (2016-08-09 16:19:51 UTC) #4
Benedikt Meurer
LGTM.
4 years, 4 months ago (2016-08-10 12:12:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228023002/1
4 years, 4 months ago (2016-08-10 12:13:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 12:36:02 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 12:36:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e8bfb5d72d17d1e6ec0954a8a867a4940111e47
Cr-Commit-Position: refs/heads/master@{#38539}

Powered by Google App Engine
This is Rietveld 408576698