Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2016)

Unified Diff: chrome/browser/net/resource_prefetch_predictor_observer.cc

Issue 2228003002: predictors: Fix duplicate content type detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/predictors/resource_prefetch_common.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/resource_prefetch_predictor_observer.cc
diff --git a/chrome/browser/net/resource_prefetch_predictor_observer.cc b/chrome/browser/net/resource_prefetch_predictor_observer.cc
index ebcba2b7ccec9b976cac3b962394fb98c158b9bb..714efc33ebcc8a612b7751393659737c6098fd5a 100644
--- a/chrome/browser/net/resource_prefetch_predictor_observer.cc
+++ b/chrome/browser/net/resource_prefetch_predictor_observer.cc
@@ -23,8 +23,8 @@ namespace {
enum RequestStats {
REQUEST_STATS_TOTAL_RESPONSES = 0,
REQUEST_STATS_TOTAL_PROCESSED_RESPONSES = 1,
- REQUEST_STATS_NO_RESOURCE_REQUEST_INFO = 2,
- REQUEST_STATS_NO_RENDER_FRAME_ID_FROM_REQUEST_INFO = 3,
+ REQUEST_STATS_NO_RESOURCE_REQUEST_INFO = 2, // Not recorded (never was).
+ REQUEST_STATS_NO_RENDER_FRAME_ID_FROM_REQUEST_INFO = 3, // Not recorded.
REQUEST_STATS_MAX = 4,
};
@@ -51,42 +51,6 @@ void ReportMainFrameRequestStats(MainFrameRequestStats stat) {
MAIN_FRAME_REQUEST_STATS_MAX);
}
-bool SummarizeResponse(net::URLRequest* request,
- ResourcePrefetchPredictor::URLRequestSummary* summary) {
- const content::ResourceRequestInfo* info =
- content::ResourceRequestInfo::ForRequest(request);
- if (!info) {
- ReportRequestStats(REQUEST_STATS_NO_RESOURCE_REQUEST_INFO);
- return false;
- }
-
- int render_process_id, render_frame_id;
- if (!info->GetAssociatedRenderFrame(&render_process_id, &render_frame_id)) {
- ReportRequestStats(REQUEST_STATS_NO_RENDER_FRAME_ID_FROM_REQUEST_INFO);
- return false;
- }
-
- summary->navigation_id.render_process_id = render_process_id;
- summary->navigation_id.render_frame_id = render_frame_id;
- summary->navigation_id.main_frame_url = request->first_party_for_cookies();
- summary->navigation_id.creation_time = request->creation_time();
- summary->resource_url = request->original_url();
- summary->resource_type = info->GetResourceType();
- summary->priority = request->priority();
- request->GetMimeType(&summary->mime_type);
- summary->was_cached = request->was_cached();
-
- // Use the mime_type to determine the resource type for subresources since
- // types such as PREFETCH, SUB_RESOURCE, etc are not useful.
- if (summary->resource_type != content::RESOURCE_TYPE_MAIN_FRAME) {
- summary->resource_type =
- ResourcePrefetchPredictor::GetResourceTypeFromMimeType(
- summary->mime_type,
- summary->resource_type);
- }
- return true;
-}
-
} // namespace
namespace chrome_browser_net {
@@ -150,8 +114,10 @@ void ResourcePrefetchPredictorObserver::OnRequestRedirected(
return;
ResourcePrefetchPredictor::URLRequestSummary summary;
- if (!SummarizeResponse(request, &summary))
+ if (!ResourcePrefetchPredictor::URLRequestSummary::SummarizeResponse(
+ *request, &summary)) {
return;
+ }
summary.redirect_url = redirect_url;
@@ -184,8 +150,10 @@ void ResourcePrefetchPredictorObserver::OnResponseStarted(
if (!ResourcePrefetchPredictor::ShouldRecordResponse(request))
return;
ResourcePrefetchPredictor::URLRequestSummary summary;
- if (!SummarizeResponse(request, &summary))
+ if (!ResourcePrefetchPredictor::URLRequestSummary::SummarizeResponse(
+ *request, &summary)) {
return;
+ }
BrowserThread::PostTask(
BrowserThread::UI,
« no previous file with comments | « no previous file | chrome/browser/predictors/resource_prefetch_common.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698