Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index ed902d4faed4463a07822c87c9bc8adaffd06e84..d8b4d86f41b2e924f804424e20d150110d949bf8 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -35332,13 +35332,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="NewTabPage.RequestThrottler.PerDay" units="requests"> |
| <owner>jkrcal@chromium.org</owner> |
| <summary> |
| - Records how many requests of the given type the browser tried to perform |
| - each day where the type is specified by the _suffix of the histogram. The |
| - histogram is emitted only after midnight of the given day passes - right |
| - before the first following request (which can be several days later if the |
| - user does not use Chrome in the meantime). The histogram counts requests |
| - with both QUOTA_GRANTED and QUOTA_EXCEEDED status, i.e. the count can easily |
| - exceed the daily quota. Forced requests are not counted here. |
| + Records how many background requests of the given type the browser tried to |
| + perform each day where the type is specified by the _suffix of the |
| + histogram. The histogram is emitted only after midnight of the given day |
| + passes - right before the first following request (which can be several days |
| + later if the user does not use Chrome in the meantime). The histogram counts |
| + requests with both QUOTA_GRANTED and QUOTA_EXCEEDED status, i.e. the count |
| + can easily exceed the daily quota. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="NewTabPage.RequestThrottler.PerDayInteractive" |
| + units="requests"> |
| + <owner>jkrcal@chromium.org</owner> |
| + <summary> |
| + Records how many interactive requests of the given type the browser tried to |
| + perform each day where the type is specified by the _suffix of the |
| + histogram. The histogram is emitted only after midnight of the given day |
| + passes - right before the first following request (which can be several days |
| + later if the user does not use Chrome in the meantime). The histogram counts |
| + requests with both QUOTA_GRANTED and QUOTA_EXCEEDED status, i.e. the count |
| + can easily exceed the daily quota. |
| </summary> |
| </histogram> |
| @@ -86177,9 +86191,10 @@ To add a new entry, add it with any value and run test to compute valid value. |
| </enum> |
| <enum name="NtpRequestThrottlerStatus" type="int"> |
| - <int value="0" label="Forced request"/> |
| - <int value="1" label="Quota granted"/> |
| - <int value="2" label="Quota exceeded"/> |
| + <int value="0" label="Interactive request - granted"/> |
|
gayane -on leave until 09-2017
2016/08/10 18:47:54
nit: maybe "Interactive request - quota granted" t
jkrcal
2016/08/11 08:06:28
Done.
|
| + <int value="1" label="Background request - granted"/> |
| + <int value="2" label="Background request - quota exceeded"/> |
| + <int value="3" label="Interactive request - quota exceeded"/> |
| </enum> |
| <enum name="NtpSnippetsFetchResult" type="int"> |
| @@ -101513,6 +101528,7 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <suffix name="SuggestionFetcher" |
| label="Fetcher for content suggestions on mobile NTP"/> |
| <affected-histogram name="NewTabPage.RequestThrottler.PerDay"/> |
| + <affected-histogram name="NewTabPage.RequestThrottler.PerDayInteractive"/> |
| <affected-histogram name="NewTabPage.RequestThrottler.RequestStatus"/> |
| </histogram_suffixes> |