Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2227973002: Add request throttler to thumbnail fetching for articles on mobile NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing the compile error Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/ntp_snippets/request_throttler_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index b58432248bb663f63c5decdeca1fa6413b0347d1..2adc4ee9957dbb24de1c600bb2dc60a32868303f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -35359,13 +35359,27 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="NewTabPage.RequestThrottler.PerDay" units="requests">
<owner>jkrcal@chromium.org</owner>
<summary>
- Records how many requests of the given type the browser tried to perform
- each day where the type is specified by the _suffix of the histogram. The
- histogram is emitted only after midnight of the given day passes - right
- before the first following request (which can be several days later if the
- user does not use Chrome in the meantime). The histogram counts requests
- with both QUOTA_GRANTED and QUOTA_EXCEEDED status, i.e. the count can easily
- exceed the daily quota. Forced requests are not counted here.
+ Records how many background requests of the given type the browser tried to
+ perform each day where the type is specified by the _suffix of the
+ histogram. The histogram is emitted only after midnight of the given day
+ passes - right before the first following request (which can be several days
+ later if the user does not use Chrome in the meantime). The histogram counts
+ requests with both QUOTA_GRANTED and QUOTA_EXCEEDED status, i.e. the count
+ can easily exceed the daily quota.
+ </summary>
+</histogram>
+
+<histogram name="NewTabPage.RequestThrottler.PerDayInteractive"
rkaplow 2016/08/11 17:13:15 where is this being recorded? I don't see "PerDayI
jkrcal 2016/08/12 09:08:19 Oh, I was not very focused, yesterday :| Thanks fo
+ units="requests">
+ <owner>jkrcal@chromium.org</owner>
+ <summary>
+ Records how many interactive requests of the given type the browser tried to
+ perform each day where the type is specified by the _suffix of the
+ histogram. The histogram is emitted only after midnight of the given day
+ passes - right before the first following request (which can be several days
+ later if the user does not use Chrome in the meantime). The histogram counts
+ requests with both QUOTA_GRANTED and QUOTA_EXCEEDED status, i.e. the count
+ can easily exceed the daily quota.
</summary>
</histogram>
@@ -86288,9 +86302,10 @@ To add a new entry, add it with any value and run test to compute valid value.
</enum>
<enum name="NtpRequestThrottlerStatus" type="int">
rkaplow 2016/08/11 17:13:15 hm, if you're changing the meaning of the histogra
jkrcal 2016/08/12 09:08:19 It is not very obvious but the meaning of the buck
- <int value="0" label="Forced request"/>
- <int value="1" label="Quota granted"/>
- <int value="2" label="Quota exceeded"/>
+ <int value="0" label="Interactive request - quota granted"/>
+ <int value="1" label="Background request - quota granted"/>
+ <int value="2" label="Background request - quota exceeded"/>
+ <int value="3" label="Interactive request - quota exceeded"/>
</enum>
<enum name="NtpSnippetsFetchResult" type="int">
@@ -101635,7 +101650,10 @@ To add a new entry, add it with any value and run test to compute valid value.
<histogram_suffixes name="RequestThrottlerTypes">
<suffix name="SuggestionFetcher"
label="Fetcher for content suggestions on mobile NTP"/>
+ <suffix name="SuggestionThumbnailFetcher"
+ label="Fetcher for article thumbnails on mobile NTP"/>
<affected-histogram name="NewTabPage.RequestThrottler.PerDay"/>
+ <affected-histogram name="NewTabPage.RequestThrottler.PerDayInteractive"/>
<affected-histogram name="NewTabPage.RequestThrottler.RequestStatus"/>
</histogram_suffixes>
« no previous file with comments | « components/ntp_snippets/request_throttler_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698