Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2227913002: MD History: Add tooltips for URLs on History page (Closed)

Created:
4 years, 4 months ago by lshang
Modified:
4 years, 4 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Add tooltips for URLs on History page Add tooltips for URLs in history item, which is the same as item's title displayed on UI. BUG=632593 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f1e7ade4776a53fc8ac13eb3a74acd15c65394db Cr-Commit-Position: refs/heads/master@{#410885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/md_history/history_item.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
lshang
Silently PTAL thanks...(I won't use '!' this time in case someone else knows about this ...
4 years, 4 months ago (2016-08-09 04:40:50 UTC) #4
tsergeant
lgtm
4 years, 4 months ago (2016-08-09 04:45:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227913002/1
4 years, 4 months ago (2016-08-09 23:57:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 00:05:04 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 00:06:58 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1e7ade4776a53fc8ac13eb3a74acd15c65394db
Cr-Commit-Position: refs/heads/master@{#410885}

Powered by Google App Engine
This is Rietveld 408576698