Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2227893005:
Fix a few gpu tests on Android (Closed)
|
Created:
4 years, 4 months ago by Julien Isorce Samsung Modified:
4 years, 4 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, sunnyps, cblume Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix a few gpu tests on Android
Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and
GpuProcess.no_gpu_process work on Android.
For other tests it does not make sense to run them on Android because
there is either no entry in kSoftwareRenderingListJson to trigger
or no multi gpu configuration.
About GpuProcess.skip_gpu_process, I could not reproduce the failure on
Nexus 4.
BUG=611930
R=kbr@chromium.org
TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a
Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751
Committed: https://crrev.com/47305c8a2024ae45a2ab870a1bf41f01a26c8ae5
Cr-Original-Original-Commit-Position: refs/heads/master@{#410998}
Cr-Original-Commit-Position: refs/heads/master@{#411213}
Cr-Commit-Position: refs/heads/master@{#412522}
Patch Set 1 #Patch Set 2 : Rebase, fix issues about revert and make NoGpuProcessPage test work on Android #
Total comments: 5
Patch Set 3 : Just rebase #Patch Set 4 : Make DriverBugWorkaroundsUponGLRendererPage more robust on Android #
Messages
Total messages: 47 (26 generated)
Description was changed from ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell ========== to ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/09 13:22:06, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. Hi, please have a look. Thx.
This is fantastic! Thank you! I was about to comment "It looks like some tests are still disabled. I'm guessing this is because they don't make sense on Android?" Then I saw your CL description which said exactly that.
kbr@chromium.org changed reviewers: + zmo@chromium.org
Thanks for making these tests work better on Android. LGTM I'd like to ask zmo@ to take a look too at the gpu_info_collector change, at least.
lgtm
The CQ bit was checked by j.isorce@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Cr-Commit-Position: refs/heads/master@{#410998} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Cr-Commit-Position: refs/heads/master@{#410998}
Message was sent while issue was closed.
Description was changed from ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Cr-Commit-Position: refs/heads/master@{#410998} ========== to ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Cr-Commit-Position: refs/heads/master@{#410998} ==========
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2230803003/ by j.isorce@samsung.com. The reason for reverting is: Failing tests on Android https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2....
Description was changed from ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Cr-Commit-Position: refs/heads/master@{#410998} ========== to ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Cr-Commit-Position: refs/heads/master@{#410998} ==========
The new Patch Set 2 should fix all 3 failures that caused to revert this CL. https://codereview.chromium.org/2227893005/diff/20001/content/test/gpu/page_s... File content/test/gpu/page_sets/gpu_process_tests.py (left): https://codereview.chromium.org/2227893005/diff/20001/content/test/gpu/page_s... content/test/gpu/page_sets/gpu_process_tests.py:231: Cosmetic change. https://codereview.chromium.org/2227893005/diff/20001/content/test/gpu/page_s... File content/test/gpu/page_sets/gpu_process_tests.py (right): https://codereview.chromium.org/2227893005/diff/20001/content/test/gpu/page_s... content/test/gpu/page_sets/gpu_process_tests.py:180: options.AppendExtraBrowserArgs('--gpu-testing-device-id=0x0324') I made this test work on Android while I was at it. https://codereview.chromium.org/2227893005/diff/20001/content/test/gpu/page_s... content/test/gpu/page_sets/gpu_process_tests.py:302: options.AppendExtraBrowserArgs('--gpu-testing-gl-vendor=Qualcomm') This fixes one of the 3 issues that lead to revert this CL. Using a less intrusive entry will be more robust, especially when running this test on Tegra. https://codereview.chromium.org/2227893005/diff/20001/content/test/gpu/page_s... content/test/gpu/page_sets/gpu_process_tests.py:482: if sys.platform.startswith('linux') and not is_platform_android: Fixes one of the 3 issues that caused a revert. I missed that condition. Did not cause any problem with my Nexus though. https://codereview.chromium.org/2227893005/diff/20001/content/test/gpu/page_s... content/test/gpu/page_sets/gpu_process_tests.py:635: self.AddStory(SoftwareGpuProcessPage(self, expectations)) Fixes one of the 3 issues that caused a revert. See comment just above.
lgtm; please keep an eye on the bots when this lands like you did last time and revert again if necessary. Thanks.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2227893005/#ps20001 (title: "Rebase, fix issues about revert and make NoGpuProcessPage test work on Android")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2227893005/#ps40001 (title: "Just rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Cr-Commit-Position: refs/heads/master@{#410998} ========== to ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Cr-Commit-Position: refs/heads/master@{#410998} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Cr-Commit-Position: refs/heads/master@{#410998} ========== to ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Cr-Original-Commit-Position: refs/heads/master@{#410998} Cr-Commit-Position: refs/heads/master@{#411213} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Cr-Commit-Position: refs/heads/master@{#411213}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2232033003/ by j.isorce@samsung.com. The reason for reverting is: Better than yesterday but still not 100% ok, still failing one bot https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2....
Message was sent while issue was closed.
Description was changed from ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Cr-Original-Commit-Position: refs/heads/master@{#410998} Cr-Commit-Position: refs/heads/master@{#411213} ========== to ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Cr-Original-Commit-Position: refs/heads/master@{#410998} Cr-Commit-Position: refs/heads/master@{#411213} ==========
I will wait until next week before another try because I would like to have a go on another CL: https://codereview.chromium.org/2153373002/ .
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/11 17:06:18, Julien Isorce wrote: > I will wait until next week before another try because I would like to have a go > on another CL: https://codereview.chromium.org/2153373002/ . I uploaded Patch Set 4. I am going to submit it to CQ, I will keep an eye on the bots when this lands, and create a revert again if necessary.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2227893005/#ps60001 (title: "Make DriverBugWorkaroundsUponGLRendererPage more robust on Android")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Cr-Original-Commit-Position: refs/heads/master@{#410998} Cr-Commit-Position: refs/heads/master@{#411213} ========== to ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Cr-Original-Commit-Position: refs/heads/master@{#410998} Cr-Commit-Position: refs/heads/master@{#411213} ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Cr-Original-Commit-Position: refs/heads/master@{#410998} Cr-Commit-Position: refs/heads/master@{#411213} ========== to ========== Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Committed: https://crrev.com/47305c8a2024ae45a2ab870a1bf41f01a26c8ae5 Cr-Original-Original-Commit-Position: refs/heads/master@{#410998} Cr-Original-Commit-Position: refs/heads/master@{#411213} Cr-Commit-Position: refs/heads/master@{#412522} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/47305c8a2024ae45a2ab870a1bf41f01a26c8ae5 Cr-Commit-Position: refs/heads/master@{#412522} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
