Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 2227893005: Fix a few gpu tests on Android (Closed)

Created:
4 years, 4 months ago by Julien Isorce Samsung
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, sunnyps, cblume
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a few gpu tests on Android Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Committed: https://crrev.com/47305c8a2024ae45a2ab870a1bf41f01a26c8ae5 Cr-Original-Original-Commit-Position: refs/heads/master@{#410998} Cr-Original-Commit-Position: refs/heads/master@{#411213} Cr-Commit-Position: refs/heads/master@{#412522}

Patch Set 1 #

Patch Set 2 : Rebase, fix issues about revert and make NoGpuProcessPage test work on Android #

Total comments: 5

Patch Set 3 : Just rebase #

Patch Set 4 : Make DriverBugWorkaroundsUponGLRendererPage more robust on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -30 lines) Patch
M content/test/gpu/gpu_tests/gpu_process_expectations.py View 2 1 chunk +0 lines, -16 lines 0 comments Download
M content/test/gpu/page_sets/gpu_process_tests.py View 1 2 3 8 chunks +40 lines, -14 lines 0 comments Download
M gpu/config/gpu_info_collector_android.cc View 2 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 47 (26 generated)
Julien Isorce Samsung
On 2016/08/09 13:22:06, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 4 months ago (2016-08-09 15:24:56 UTC) #6
cblume
This is fantastic! Thank you! I was about to comment "It looks like some tests ...
4 years, 4 months ago (2016-08-09 17:23:31 UTC) #7
Ken Russell (switch to Gerrit)
Thanks for making these tests work better on Android. LGTM I'd like to ask zmo@ ...
4 years, 4 months ago (2016-08-09 17:44:41 UTC) #9
Zhenyao Mo
lgtm
4 years, 4 months ago (2016-08-09 21:03:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227893005/1
4 years, 4 months ago (2016-08-10 07:38:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 07:43:05 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Cr-Commit-Position: refs/heads/master@{#410998}
4 years, 4 months ago (2016-08-10 07:44:52 UTC) #15
Julien Isorce Samsung
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2230803003/ by j.isorce@samsung.com. ...
4 years, 4 months ago (2016-08-10 10:12:12 UTC) #17
Julien Isorce Samsung
The new Patch Set 2 should fix all 3 failures that caused to revert this ...
4 years, 4 months ago (2016-08-10 12:54:55 UTC) #19
Ken Russell (switch to Gerrit)
lgtm; please keep an eye on the bots when this lands like you did last ...
4 years, 4 months ago (2016-08-10 19:52:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227893005/20001
4 years, 4 months ago (2016-08-10 21:43:21 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/49903) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-10 21:47:16 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227893005/40001
4 years, 4 months ago (2016-08-10 22:09:13 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-11 01:19:49 UTC) #30
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Cr-Commit-Position: refs/heads/master@{#411213}
4 years, 4 months ago (2016-08-11 01:21:50 UTC) #32
Julien Isorce Samsung
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2232033003/ by j.isorce@samsung.com. ...
4 years, 4 months ago (2016-08-11 06:15:51 UTC) #33
Julien Isorce Samsung
I will wait until next week before another try because I would like to have ...
4 years, 4 months ago (2016-08-11 17:06:18 UTC) #35
Julien Isorce Samsung
On 2016/08/11 17:06:18, Julien Isorce wrote: > I will wait until next week before another ...
4 years, 4 months ago (2016-08-17 14:27:50 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227893005/60001
4 years, 4 months ago (2016-08-17 14:29:02 UTC) #43
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-17 14:35:28 UTC) #45
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 14:37:51 UTC) #47
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/47305c8a2024ae45a2ab870a1bf41f01a26c8ae5
Cr-Commit-Position: refs/heads/master@{#412522}

Powered by Google App Engine
This is Rietveld 408576698