Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2227863002: aw: Add new entry point into webview (Closed)

Created:
4 years, 4 months ago by boliu
Modified:
4 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Add new entry point into webview Using a static method allows flexibility to create a different Provider depending on the version of Android. BUG=635895 Committed: https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd Cr-Commit-Position: refs/heads/master@{#410660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
boliu
ptal, better this start soon I think..
4 years, 4 months ago (2016-08-08 23:22:44 UTC) #2
Torne
lgtm
4 years, 4 months ago (2016-08-09 11:18:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227863002/1
4 years, 4 months ago (2016-08-09 13:37:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227863002/1
4 years, 4 months ago (2016-08-09 13:43:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 14:25:25 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 14:29:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81f3b374d223cfb02340ff52b3fe32f9715f4fcd
Cr-Commit-Position: refs/heads/master@{#410660}

Powered by Google App Engine
This is Rietveld 408576698