SkLiteRecorder: don't tell SkCanvas about clips

SkLiteRecorder: don't tell SkCanvas about clips

If no one reads our clip, and we don't expect quickReject() to help,
we can probably get away without maintaining a proper clip stack.

This puts us at about 0.6-0.7x of previous record cost.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2227833004

Committed: https://skia.googlesource.com/skia/+/8369e32a05543c2619b1d7e740fe6ff6d2f03af3

[mtklein_C, 2016-08-08 23:02:46]

Description was changed from

==========
SkLiteRecorder: don't tell SkCanvas about clips

If no one reads our clip, and we don't expect quickReject() to help,
we can probably get away without maintaining a proper clip stack.

BUG=skia:
==========

to

==========
SkLiteRecorder: don't tell SkCanvas about clips

If no one reads our clip, and we don't expect quickReject() to help,
we can probably get away without maintaining a proper clip stack.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2227833004
==========

[mtklein_C, 2016-08-08 23:03:22]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 23:03:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-08 23:04:15]

Description was changed from

==========
SkLiteRecorder: don't tell SkCanvas about clips

If no one reads our clip, and we don't expect quickReject() to help,
we can probably get away without maintaining a proper clip stack.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2227833004
==========

to

==========
SkLiteRecorder: don't tell SkCanvas about clips

If no one reads our clip, and we don't expect quickReject() to help,
we can probably get away without maintaining a proper clip stack.

This puts us at about 0.6-0.7x of previous record cost.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2227833004
==========

[commit-bot: I haz the power, 2016-08-08 23:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:23:55]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2016-08-08 23:50:18]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[mtklein_C, 2016-08-08 23:50:18]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-08-08 23:50:19]

I honestly didn't think it'd be this easy.

We should consider doing this for SkRecorder.cpp too, given that there are no GM
diffs.

[commit-bot: I haz the power, 2016-08-08 23:50:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-08-09 14:17:07]

lgtm

does your comment mean this change improves previous Lite recording by 30%?

[mtklein, 2016-08-09 14:17:26]

On 2016/08/09 14:17:07, reed1 wrote:
> lgtm
> 
> does your comment mean this change improves previous Lite recording by 30%?

Yes, for clip-heavy loads.

[commit-bot: I haz the power, 2016-08-09 14:19:05]

Description was changed from

==========
SkLiteRecorder: don't tell SkCanvas about clips

If no one reads our clip, and we don't expect quickReject() to help,
we can probably get away without maintaining a proper clip stack.

This puts us at about 0.6-0.7x of previous record cost.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2227833004
==========

to

==========
SkLiteRecorder: don't tell SkCanvas about clips

If no one reads our clip, and we don't expect quickReject() to help,
we can probably get away without maintaining a proper clip stack.

This puts us at about 0.6-0.7x of previous record cost.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2227833004

Committed:
https://skia.googlesource.com/skia/+/8369e32a05543c2619b1d7e740fe6ff6d2f03af3
==========

[commit-bot: I haz the power, 2016-08-09 14:19:09]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8369e32a05543c2619b1d7e740fe6ff6d2f03af3

[mtklein, 2016-08-31 19:47:06]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-08-31 19:47:07]

Can try reverting this?

[liyuqian, 2016-09-12 19:10:44]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2335773002/ by liyuqian@google.com.

The reason for reverting is: This CL breaks Android CTS tests
CanvasStateTests#testClipPathReturnValues,
CanvasStateTests#testClipRectReturnValues, and CanvasStateTests#testQuickReject.

Reverting it won't significantly affect Android's performance. See the following
Jank test result. (Derek said that this is the only test closely related to this
CL.)

**After reverting**
INSTRUMENTATION_STATUS: gfx-max-slow-draw=0.0
INSTRUMENTATION_STATUS: gfx-max-high-input-latency=0.0
INSTRUMENTATION_STATUS: gfx-max-slow-ui-thread=100.0
INSTRUMENTATION_STATUS: gfx-avg-slow-bitmap-uploads=100.0
INSTRUMENTATION_STATUS: gfx-avg-missed-vsync=72.96467105972435
INSTRUMENTATION_STATUS: gfx-avg-high-input-latency=0.0
INSTRUMENTATION_STATUS: gfx-max-slow-bitmap-uploads=100.0
INSTRUMENTATION_STATUS: gfx-max-missed-vsync=73.56181150550796
INSTRUMENTATION_STATUS: gfx-avg-frame-time-90=69.0
INSTRUMENTATION_STATUS: gfx-avg-frame-time-95=69.0
INSTRUMENTATION_STATUS: gfx-avg-frame-time-99=69.0
INSTRUMENTATION_STATUS: gfx-max-jank=100.0
INSTRUMENTATION_STATUS: gfx-avg-slow-draw=0.0
INSTRUMENTATION_STATUS: gfx-avg-slow-ui-thread=100.0
INSTRUMENTATION_STATUS: gfx-max-frame-time-90=69
INSTRUMENTATION_STATUS: gfx-max-frame-time-95=69
INSTRUMENTATION_STATUS: gfx-max-frame-time-99=69
INSTRUMENTATION_STATUS: gfx-avg-jank=100.0
INSTRUMENTATION_STATUS_CODE: -1
.
Test results for InstrumentationTestRunner=.
Time: 77.404

**Before Reverting**
gfx-max-slow-draw=1.1135857461024499
INSTRUMENTATION_STATUS: gfx-max-high-input-latency=0.0
INSTRUMENTATION_STATUS: gfx-max-slow-ui-thread=100.0
INSTRUMENTATION_STATUS: gfx-avg-slow-bitmap-uploads=100.0
INSTRUMENTATION_STATUS: gfx-avg-missed-vsync=70.79687591131983
INSTRUMENTATION_STATUS: gfx-avg-high-input-latency=0.0
INSTRUMENTATION_STATUS: gfx-max-slow-bitmap-uploads=100.0
INSTRUMENTATION_STATUS: gfx-max-missed-vsync=76.94174757281553
INSTRUMENTATION_STATUS: gfx-avg-frame-time-90=67.66666666666667
INSTRUMENTATION_STATUS: gfx-avg-frame-time-95=67.66666666666667
INSTRUMENTATION_STATUS: gfx-avg-frame-time-99=69.0
INSTRUMENTATION_STATUS: gfx-max-jank=100.0
INSTRUMENTATION_STATUS: gfx-avg-slow-draw=0.5317509395832639
INSTRUMENTATION_STATUS: gfx-avg-slow-ui-thread=100.0
INSTRUMENTATION_STATUS: gfx-max-frame-time-90=69
INSTRUMENTATION_STATUS: gfx-max-frame-time-95=69
INSTRUMENTATION_STATUS: gfx-max-frame-time-99=69
INSTRUMENTATION_STATUS: gfx-avg-jank=100.0
INSTRUMENTATION_STATUS_CODE: -1
.
Test results for InstrumentationTestRunner=.
Time: 77.411

OK (1 test)
.