Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: media/filters/legacy_frame_processor.h

Issue 222783007: Consider text tracks in the frame processor for new media segments. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DCHECK. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/legacy_frame_processor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/legacy_frame_processor.h
diff --git a/media/filters/legacy_frame_processor.h b/media/filters/legacy_frame_processor.h
index 46da312b0509c702983f309e36b62379549592fd..c37dd7b21dbea0802d6516c2660da3d591d55196 100644
--- a/media/filters/legacy_frame_processor.h
+++ b/media/filters/legacy_frame_processor.h
@@ -63,18 +63,21 @@ class MEDIA_EXPORT LegacyFrameProcessor : public FrameProcessorBase {
// Helper function for Legacy ProcessFrames() when new text buffers have been
// parsed.
// Applies |timestamp_offset| to all buffers in |buffers|, filters |buffers|
- // with append window, and then appends the modified and filtered buffers to
- // the stream associated with the track having |text_track_id|. If any of
- // |buffers| are filtered out by append window, then |*new_media_segment| is
- // set true.
+ // with append window, and stores those filtered buffers into |filtered_text|
+ // based on |text_track_id|. If any of |buffers| are filtered out by append
+ // window, then |*new_media_segment| is set true.
+ // Updates |lowest_segment_timestamp| to be the earliest decode timestamp of
+ // all buffers in |filtered_text|.
// Returns true on a successful call. Returns false if an error occurred while
// processing the buffers.
- bool OnTextBuffers(StreamParser::TrackId text_track_id,
- base::TimeDelta append_window_start,
- base::TimeDelta append_window_end,
- base::TimeDelta timestamp_offset,
- const StreamParser::BufferQueue& buffers,
- bool* new_media_segment);
+ bool FilterTextBuffers(StreamParser::TrackId text_track_id,
+ base::TimeDelta append_window_start,
+ base::TimeDelta append_window_end,
+ base::TimeDelta timestamp_offset,
+ const StreamParser::BufferQueue& buffers,
+ bool* new_media_segment,
+ base::TimeDelta* lowest_segment_timestamp,
+ StreamParser::TextBufferQueueMap* filtered_text);
IncreaseDurationCB increase_duration_cb_;
« no previous file with comments | « no previous file | media/filters/legacy_frame_processor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698