Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2227803003: Plumb phase/momentum for WheelEvent. (Closed)

Created:
4 years, 4 months ago by wjmaclean
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-events_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb phase/momentum for WheelEvent. A simple patch to plumb the MacOS rubber-banding parameters from PlatformWheelEvent to WheelEvent, and from WheelEvent to WebMouseWheelEvent. This CL also removes the canRubberbandX pathways, as they are not used. BUG=628742 Committed: https://crrev.com/0e5881c9fb0e35da5c5854ccc1056ffda357a58a Cr-Commit-Position: refs/heads/master@{#411201}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove canRubberband{Left|Right}, add STATIC_ASSERTS for enums. #

Patch Set 3 : Fix Non-Mac compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -118 lines) Patch
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm View 1 1 chunk +0 lines, -40 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_mac.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_mac.mm View 1 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 chunks +2 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/input/web_input_event_traits.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/browser/render_widget_host_view_mac_delegate.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/WheelEvent.h View 1 5 chunks +39 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/WheelEvent.cpp View 1 3 chunks +39 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PlatformWheelEvent.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 1 8 chunks +32 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 1 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 39 (23 generated)
wjmaclean
Fairly straightforward plumbing (I think) ... ptal?
4 years, 4 months ago (2016-08-09 18:59:01 UTC) #4
esprehn
I think you want to add a bunch of static asserts. https://codereview.chromium.org/2227803003/diff/1/third_party/WebKit/public/platform/WebInputEvent.h File third_party/WebKit/public/platform/WebInputEvent.h (right): ...
4 years, 4 months ago (2016-08-09 19:14:13 UTC) #5
dtapuska
On 2016/08/09 19:14:13, esprehn wrote: > I think you want to add a bunch of ...
4 years, 4 months ago (2016-08-09 19:19:33 UTC) #6
wjmaclean
Revised as per comments, adding avi@ for content/ review.
4 years, 4 months ago (2016-08-09 22:13:34 UTC) #14
wjmaclean
On 2016/08/09 22:13:34, wjmaclean wrote: > Revised as per comments, adding avi@ for content/ review. ...
4 years, 4 months ago (2016-08-09 22:13:59 UTC) #15
Avi (use Gerrit)
content lgtm
4 years, 4 months ago (2016-08-09 22:58:44 UTC) #18
wjmaclean
esprehn@ - ptal?
4 years, 4 months ago (2016-08-10 20:14:19 UTC) #23
esprehn
lgtm
4 years, 4 months ago (2016-08-10 20:21:28 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227803003/40001
4 years, 4 months ago (2016-08-10 20:28:52 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/235271)
4 years, 4 months ago (2016-08-10 20:37:09 UTC) #29
wjmaclean
thestig@ - Can you please do an OWNERs check for chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h Presubmit is unhappy with ...
4 years, 4 months ago (2016-08-10 20:43:51 UTC) #31
Lei Zhang
On 2016/08/10 20:43:51, wjmaclean wrote: > thestig@ - Can you please do an OWNERs check ...
4 years, 4 months ago (2016-08-10 20:49:48 UTC) #32
wjmaclean
On 2016/08/10 20:49:48, Lei Zhang (Soon to be OOO) wrote: > On 2016/08/10 20:43:51, wjmaclean ...
4 years, 4 months ago (2016-08-10 20:50:39 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227803003/40001
4 years, 4 months ago (2016-08-10 20:51:37 UTC) #35
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-11 00:28:14 UTC) #37
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 00:29:24 UTC) #39
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e5881c9fb0e35da5c5854ccc1056ffda357a58a
Cr-Commit-Position: refs/heads/master@{#411201}

Powered by Google App Engine
This is Rietveld 408576698