Plumb phase/momentum for WheelEvent.

Plumb phase/momentum for WheelEvent.

A simple patch to plumb the MacOS rubber-banding parameters from
PlatformWheelEvent to WheelEvent, and from WheelEvent to
WebMouseWheelEvent.
This CL also removes the canRubberbandX pathways, as they are not used.

BUG=628742
Committed: https://crrev.com/0e5881c9fb0e35da5c5854ccc1056ffda357a58a
Cr-Commit-Position: refs/heads/master@{#411201}

[wjmaclean, 2016-08-09 18:57:27]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 18:57:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wjmaclean, 2016-08-09 18:59:01]

wjmaclean@chromium.org changed reviewers:
+ esprehn@chromium.org

[wjmaclean, 2016-08-09 18:59:01]

Fairly straightforward plumbing (I think) ... ptal?

[esprehn, 2016-08-09 19:14:13]

I think you want to add a bunch of static asserts.

https://codereview.chromium.org/2227803003/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebInputEvent.h (right):

https://codereview.chromium.org/2227803003/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebInputEvent.h:398: // sync with that used
for the corresponding types.
We usually use static_asserts to enforce parallel enums.

[dtapuska, 2016-08-09 19:19:33]

On 2016/08/09 19:14:13, esprehn wrote:
> I think you want to add a bunch of static asserts.
> 
>
https://codereview.chromium.org/2227803003/diff/1/third_party/WebKit/public/p...
> File third_party/WebKit/public/platform/WebInputEvent.h (right):
> 
>
https://codereview.chromium.org/2227803003/diff/1/third_party/WebKit/public/p...
> third_party/WebKit/public/platform/WebInputEvent.h:398: // sync with that used
> for the corresponding types.
> We usually use static_asserts to enforce parallel enums.

Remove the canrubberbandleft/right.

As I recall they aren't used in a single spot.

[commit-bot: I haz the power, 2016-08-09 21:03:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 21:03:49]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[wjmaclean, 2016-08-09 22:07:13]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[wjmaclean, 2016-08-09 22:07:24]

Description was changed from

==========
Plumb phase/momentum for WheelEvent.

A simple patch to plumb the MacOS rubber-banding parameters from
PlatformWheelEvent to WheelEvent, and from WheelEvent to
WebMouseWheelEvent.

BUG=628742
==========

to

==========
Plumb phase/momentum for WheelEvent.

A simple patch to plumb the MacOS rubber-banding parameters from
PlatformWheelEvent to WheelEvent, and from WheelEvent to
WebMouseWheelEvent.

BUG=628742
==========

[wjmaclean, 2016-08-09 22:07:24]

wjmaclean@chromium.org changed reviewers:
+ avi@chromium.org

[commit-bot: I haz the power, 2016-08-09 22:07:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wjmaclean, 2016-08-09 22:08:13]

Description was changed from

==========
Plumb phase/momentum for WheelEvent.

A simple patch to plumb the MacOS rubber-banding parameters from
PlatformWheelEvent to WheelEvent, and from WheelEvent to
WebMouseWheelEvent.

BUG=628742
==========

to

==========
Plumb phase/momentum for WheelEvent.

A simple patch to plumb the MacOS rubber-banding parameters from
PlatformWheelEvent to WheelEvent, and from WheelEvent to
WebMouseWheelEvent.
This CL also removes the canRubberbandX pathways, as they are not used.

BUG=628742
==========

[wjmaclean, 2016-08-09 22:13:34]

Revised as per comments, adding avi@ for content/ review.

[wjmaclean, 2016-08-09 22:13:59]

On 2016/08/09 22:13:34, wjmaclean wrote:
> Revised as per comments, adding avi@ for content/ review.

And avi for chrome/ review.

[commit-bot: I haz the power, 2016-08-09 22:46:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 22:46:05]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Avi (use Gerrit), 2016-08-09 22:58:44]

content lgtm

[wjmaclean, 2016-08-10 13:15:29]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 13:15:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 19:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 19:19:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[wjmaclean, 2016-08-10 20:14:19]

esprehn@ - ptal?

[esprehn, 2016-08-10 20:21:28]

lgtm

[wjmaclean, 2016-08-10 20:28:09]

The CQ bit was checked by wjmaclean@chromium.org

[wjmaclean, 2016-08-10 20:28:09]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2227803003/#ps40001
(title: "Fix Non-Mac compile.")

[commit-bot: I haz the power, 2016-08-10 20:28:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 20:37:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 20:37:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[wjmaclean, 2016-08-10 20:43:50]

wjmaclean@chromium.org changed reviewers:
+ thestig@chromium.org

[wjmaclean, 2016-08-10 20:43:51]

thestig@ - Can you please do an OWNERs check for

chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h

Presubmit is unhappy with reviews I have thus far ...

[Lei Zhang, 2016-08-10 20:49:48]

On 2016/08/10 20:43:51, wjmaclean wrote:
> thestig@ - Can you please do an OWNERs check for
> 
>
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h
> 
> Presubmit is unhappy with reviews I have thus far ...

rs lgtm

[wjmaclean, 2016-08-10 20:50:39]

On 2016/08/10 20:49:48, Lei Zhang (Soon to be OOO) wrote:
> On 2016/08/10 20:43:51, wjmaclean wrote:
> > thestig@ - Can you please do an OWNERs check for
> > 
> >
>
chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h
> > 
> > Presubmit is unhappy with reviews I have thus far ...
> 
> rs lgtm

Thanks!

[wjmaclean, 2016-08-10 20:50:46]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2016-08-10 20:51:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 00:28:12]

Description was changed from

==========
Plumb phase/momentum for WheelEvent.

A simple patch to plumb the MacOS rubber-banding parameters from
PlatformWheelEvent to WheelEvent, and from WheelEvent to
WebMouseWheelEvent.
This CL also removes the canRubberbandX pathways, as they are not used.

BUG=628742
==========

to

==========
Plumb phase/momentum for WheelEvent.

A simple patch to plumb the MacOS rubber-banding parameters from
PlatformWheelEvent to WheelEvent, and from WheelEvent to
WebMouseWheelEvent.
This CL also removes the canRubberbandX pathways, as they are not used.

BUG=628742
==========

[commit-bot: I haz the power, 2016-08-11 00:28:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 00:29:22]

Description was changed from

==========
Plumb phase/momentum for WheelEvent.

A simple patch to plumb the MacOS rubber-banding parameters from
PlatformWheelEvent to WheelEvent, and from WheelEvent to
WebMouseWheelEvent.
This CL also removes the canRubberbandX pathways, as they are not used.

BUG=628742
==========

to

==========
Plumb phase/momentum for WheelEvent.

A simple patch to plumb the MacOS rubber-banding parameters from
PlatformWheelEvent to WheelEvent, and from WheelEvent to
WebMouseWheelEvent.
This CL also removes the canRubberbandX pathways, as they are not used.

BUG=628742

Committed: https://crrev.com/0e5881c9fb0e35da5c5854ccc1056ffda357a58a
Cr-Commit-Position: refs/heads/master@{#411201}
==========

[commit-bot: I haz the power, 2016-08-11 00:29:24]

Patchset 3 (id:??) landed as
https://crrev.com/0e5881c9fb0e35da5c5854ccc1056ffda357a58a
Cr-Commit-Position: refs/heads/master@{#411201}