Mirror filters and sort preferences to url-params

Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

Default filters, column headers, and column contents were added.

Many Aliases were added.

The Limit box will correct itself if you type outside the range of 1-1000

Additionally, a new npm package "skia-common-js" was added, to avoid 
duplication of code.

BUG=631047
Committed: https://github.com/luci/luci-py/commit/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99

[kjlubick, 2016-08-10 15:35:32]

Description was changed from

==========
POC url-params

BUG=
==========

to

==========
Mirror filters and sort preferences to url-params

BUG=631047
==========

[kjlubick, 2016-08-10 15:35:32]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-08-10 19:02:15]

Description was changed from

==========
Mirror filters and sort preferences to url-params

BUG=631047
==========

to

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over

BUG=631047
==========

[kjlubick, 2016-08-10 19:03:31]

Description was changed from

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over

BUG=631047
==========

to

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

BUG=631047
==========

[kjlubick, 2016-08-10 19:04:39]

https://screenshot.googleplex.com/5G6LSkeO8gq

https://2243-e448e8e-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newu...

This is the last big set of features on the botlist. I'm probably not going to
touch it much until the whole thing goes to prod, or I get feedback of things
being broken.

[kjlubick, 2016-08-10 19:05:10]

Description was changed from

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

BUG=631047
==========

to

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

Additionally, a new npm package "skia-common-js" was added, to avoid 
duplication of code.

BUG=631047
==========

[stephana, 2016-08-11 17:09:53]

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
File appengine/swarming/elements/Makefile (right):

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
appengine/swarming/elements/Makefile:25: ./node_modules/.bin/uglifyjs
./node_modules/skia-common-js/common.js -o ./build/js/sk.js
Is there are reason why the JS files are not all concatenated and then uglified
into one file ?

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/botlist/bot-list-data.html (right):

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/botlist/bot-list-data.html:101: type:
Object,
Does this need a default value ?

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/common/url-param.html (right):

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/common/url-param.html:6: This element
requires version 1.0.1 or greater of the npm package
IMO, requirements should be lower down in the docs. Firstly it should tell what
the element is and does.

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/common/url-param.html:109: getURL: function
() {
getURL should be documented if it's part of the API of this element or be
renamed to _getURL if it's an internal function. 
Same for other functions.

[kjlubick, 2016-08-11 20:00:22]

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
File appengine/swarming/elements/Makefile (right):

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
appengine/swarming/elements/Makefile:25: ./node_modules/.bin/uglifyjs
./node_modules/skia-common-js/common.js -o ./build/js/sk.js
On 2016/08/11 at 17:09:53, stephana wrote:
> Is there are reason why the JS files are not all concatenated and then
uglified into one file ?

I guess not.  Done.

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/botlist/bot-list-data.html (right):

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/botlist/bot-list-data.html:101: type:
Object,
On 2016/08/11 at 17:09:53, stephana wrote:
> Does this need a default value ?

No. Polymer best practices say to use default values only where actually needed
for performance reasons.  If left empty, it will remain undefined until it is
computed upstream and everything in this element is totally cool with that.

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/common/url-param.html (right):

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/common/url-param.html:6: This element
requires version 1.0.1 or greater of the npm package
On 2016/08/11 at 17:09:53, stephana wrote:
> IMO, requirements should be lower down in the docs. Firstly it should tell
what the element is and does.

Done.

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/common/url-param.html:109: getURL: function
() {
On 2016/08/11 at 17:09:53, stephana wrote:
> getURL should be documented if it's part of the API of this element or be
renamed to _getURL if it's an internal function. 
> Same for other functions.

Done.

[stephana, 2016-08-12 14:45:59]

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/botlist/bot-list-data.html (right):

https://codereview.chromium.org/2227803002/diff/100001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/botlist/bot-list-data.html:101: type:
Object,
On 2016/08/11 20:00:21, kjlubick wrote:
> On 2016/08/11 at 17:09:53, stephana wrote:
> > Does this need a default value ?
> 
> No. Polymer best practices say to use default values only where actually
needed
> for performance reasons.  If left empty, it will remain undefined until it is
> computed upstream and everything in this element is totally cool with that.

Acknowledged.

https://codereview.chromium.org/2227803002/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/botlist/bot-filters.html (right):

https://codereview.chromium.org/2227803002/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/botlist/bot-filters.html:31: and is_dead:
String.
Nit: Does that mean the query_params object should look something like this:

{
  "dimensions": ["x", "y", "z"], 
  "quarantined": "string", 
  "is_dead" : "string", 
} 

if so that should be clearer and also what the possible values can be.

[kjlubick, 2016-08-12 15:38:19]

https://codereview.chromium.org/2227803002/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/botlist/bot-filters.html (right):

https://codereview.chromium.org/2227803002/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/botlist/bot-filters.html:31: and is_dead:
String.
On 2016/08/12 at 14:45:59, stephana wrote:
> Nit: Does that mean the query_params object should look something like this:
> 
> {
>   "dimensions": ["x", "y", "z"], 
>   "quarantined": "string", 
>   "is_dead" : "string", 
> } 
> 
> if so that should be clearer and also what the possible values can be.

Done.

[stephana, 2016-08-12 18:07:11]

On 2016/08/12 15:38:19, kjlubick wrote:
>
https://codereview.chromium.org/2227803002/diff/120001/appengine/swarming/ele...
> File appengine/swarming/elements/res/imp/botlist/bot-filters.html (right):
> 
>
https://codereview.chromium.org/2227803002/diff/120001/appengine/swarming/ele...
> appengine/swarming/elements/res/imp/botlist/bot-filters.html:31: and is_dead:
> String.
> On 2016/08/12 at 14:45:59, stephana wrote:
> > Nit: Does that mean the query_params object should look something like this:
> > 
> > {
> >   "dimensions": ["x", "y", "z"], 
> >   "quarantined": "string", 
> >   "is_dead" : "string", 
> > } 
> > 
> > if so that should be clearer and also what the possible values can be.
> 
> Done.

lgtm

[kjlubick, 2016-08-12 18:14:22]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-08-12 18:14:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:14:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 18:14:33]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[kjlubick, 2016-08-12 18:14:48]

Description was changed from

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

Additionally, a new npm package "skia-common-js" was added, to avoid 
duplication of code.

BUG=631047
==========

to

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

Default filters, column headers, and column contents were added.

Many 

Additionally, a new npm package "skia-common-js" was added, to avoid 
duplication of code.

BUG=631047
==========

[kjlubick, 2016-08-12 18:15:11]

Description was changed from

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

Default filters, column headers, and column contents were added.

Many 

Additionally, a new npm package "skia-common-js" was added, to avoid 
duplication of code.

BUG=631047
==========

to

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

Default filters, column headers, and column contents were added.

Many Aliases were added.

The Limit box will correct itself if you type outside the range of 1-1000

Additionally, a new npm package "skia-common-js" was added, to avoid 
duplication of code.

BUG=631047
==========

[KevinL, 2016-08-12 18:15:29]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-08-12 18:15:30]

lgtm

[KevinL, 2016-08-12 18:15:33]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-08-12 18:15:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 18:18:57]

Description was changed from

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

Default filters, column headers, and column contents were added.

Many Aliases were added.

The Limit box will correct itself if you type outside the range of 1-1000

Additionally, a new npm package "skia-common-js" was added, to avoid 
duplication of code.

BUG=631047
==========

to

==========
Mirror filters and sort preferences to url-params

This also adds a "limit results" option to give the user control over
how many results are returned from the server.

The filters were changed from being Or'd and then And'd to being all
AND'd, which makes the client side act the same way as the server side.

Default filters, column headers, and column contents were added.

Many Aliases were added.

The Limit box will correct itself if you type outside the range of 1-1000

Additionally, a new npm package "skia-common-js" was added, to avoid 
duplication of code.

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99
==========

[commit-bot: I haz the power, 2016-08-12 18:18:59]

Committed patchset #12 (id:220001) as
https://github.com/luci/luci-py/commit/68038ad2f7c03ab543a7d8bf33a7d5a02a676c99