Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/api.py

Issue 2227783002: auto_bisect: fix path for checking DEPS (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/revision_state.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/api.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/api.py b/scripts/slave/recipe_modules/auto_bisect/api.py
index 6406671ee9523bed9d6ad508a13741f269cdeaaa..9216f213a300594303e4b17c259552704c705a18 100644
--- a/scripts/slave/recipe_modules/auto_bisect/api.py
+++ b/scripts/slave/recipe_modules/auto_bisect/api.py
@@ -51,6 +51,12 @@ class AutoBisectApi(recipe_api.RecipeApi):
# None means "default value".
self._working_dir = None
+ @property
+ def working_dir(self):
+ if not self._working_dir:
+ self._working_dir = self.m.chromium_tests.get_checkout_dir({})
+ return self._working_dir
+
def perform_bisect(self, **flags):
return local_bisect.perform_bisect(self, **flags)
@@ -211,9 +217,8 @@ class AutoBisectApi(recipe_api.RecipeApi):
skip_download=skip_download)
def ensure_checkout(self, *args, **kwargs):
- self._working_dir = self.m.chromium_tests.get_checkout_dir({})
- if self._working_dir:
- kwargs.setdefault('cwd', self._working_dir)
+ if self.working_dir:
+ kwargs.setdefault('cwd', self.working_dir)
return self.m.bot_update.ensure_checkout(*args, **kwargs)
@@ -373,8 +378,8 @@ class AutoBisectApi(recipe_api.RecipeApi):
self.bot_db = bot_db
context = {}
- if self._working_dir:
- context['cwd'] = self._working_dir
+ if self.working_dir:
+ context['cwd'] = self.working_dir
with api.step.context(context):
affected_files = self.m.tryserver.get_files_affected_by_patch()
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/revision_state.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698