Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2227763003: [turbofan] Rewrite ToObject as TurboFan stub. (Closed)

Created:
4 years, 4 months ago by Franzi
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Rewrite ToObject as TurboFan stub. Drive-by fix: Use CodeStubAssembler::LoadNativeContext() BUG=chromium:608675 Committed: https://crrev.com/9243d5e32b77ebc48bedc1d08009e9777f7aca12 Cr-Commit-Position: refs/heads/master@{#38501}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Refactor stub #

Patch Set 4 : Add comment with ES6 section #

Total comments: 6

Patch Set 5 : Use RestoreContext() instead of Push/Pop #

Patch Set 6 : Load instance type from map #

Total comments: 1

Patch Set 7 : Revert "Delete hydrogen toObject" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -55 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/x87/builtins-x87.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 5 6 4 chunks +74 lines, -9 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +33 lines, -32 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 40 (31 generated)
Franzi
Hi Benedikt, Here's ToObject as TurboFan stub. Can you have a look? I reordered some ...
4 years, 4 months ago (2016-08-09 09:59:18 UTC) #14
Michael Starzinger
https://codereview.chromium.org/2227763003/diff/60001/src/full-codegen/arm/full-codegen-arm.cc File src/full-codegen/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/2227763003/diff/60001/src/full-codegen/arm/full-codegen-arm.cc#newcode1009 src/full-codegen/arm/full-codegen-arm.cc:1009: __ Pop(cp); Please use FullCodeGenerator::RestoreContext after the call instead ...
4 years, 4 months ago (2016-08-09 10:24:29 UTC) #17
Benedikt Meurer
LGTM once comments addressed. https://codereview.chromium.org/2227763003/diff/60001/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/2227763003/diff/60001/src/code-stubs.cc#newcode2111 src/code-stubs.cc:2111: Node* instance_type = assembler->LoadInstanceType(object); Load ...
4 years, 4 months ago (2016-08-09 11:05:49 UTC) #20
Franzi
Thanks for the comments, all fixed. https://codereview.chromium.org/2227763003/diff/60001/src/code-stubs.cc File src/code-stubs.cc (right): https://codereview.chromium.org/2227763003/diff/60001/src/code-stubs.cc#newcode2111 src/code-stubs.cc:2111: Node* instance_type = ...
4 years, 4 months ago (2016-08-09 11:21:38 UTC) #24
Michael Starzinger
LGTM from my end as well. Didn't look at the actual code-stub all too close. ...
4 years, 4 months ago (2016-08-09 12:10:14 UTC) #27
Franzi
On 2016/08/09 12:10:14, Michael Starzinger wrote: > LGTM from my end as well. Didn't look ...
4 years, 4 months ago (2016-08-09 12:58:03 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2227763003/120001
4 years, 4 months ago (2016-08-09 16:12:38 UTC) #36
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 4 months ago (2016-08-09 16:14:25 UTC) #38
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 16:14:48 UTC) #40
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/9243d5e32b77ebc48bedc1d08009e9777f7aca12
Cr-Commit-Position: refs/heads/master@{#38501}

Powered by Google App Engine
This is Rietveld 408576698